Skip to content
This repository was archived by the owner on Feb 9, 2022. It is now read-only.

Moving common dev setup to istio/istio/devel#774

Merged
ldemailly merged 2 commits intomasterfrom
ldemailly_devel_docs
Jun 1, 2017
Merged

Moving common dev setup to istio/istio/devel#774
ldemailly merged 2 commits intomasterfrom
ldemailly_devel_docs

Conversation

@ldemailly
Copy link
Copy Markdown
Member

@ldemailly ldemailly commented May 31, 2017 •
edited by mandarjog
Loading

See istio/istio#352

This change is Reviewable

@ldemailly ldemailly requested review from geeknoid and xiaolanz May 31, 2017 18:27
@istio-testing
Copy link
Copy Markdown
Contributor

istio-testing commented May 31, 2017

Jenkins job mixer/presubmit passed

@istio-testing
Copy link
Copy Markdown
Contributor

istio-testing commented May 31, 2017

Jenkins job mixer/manager-regression passed

@istio-testing
Copy link
Copy Markdown
Contributor

istio-testing commented May 31, 2017

Jenkins job mixer/e2e-smoketest passed

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2017 •
edited
Loading

Codecov Report

Merging #774 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #774   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files          67       67           
  Lines        4411     4411           
=======================================
  Hits         3870     3870           
  Misses        453      453           
  Partials       88       88

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6fd5ef...59cd7b2. Read the comment docs.

geeknoid
geeknoid suggested changes Jun 1, 2017
View reviewed changes
Comment thread doc/dev/development.md
@@ -1,336 +1,12 @@
# Development Guide
Copy link
Copy Markdown
Contributor

@geeknoid geeknoid Jun 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this file completely and just point the README.md (along with any other references) directly to the istio/istio location.

Copy link
Copy Markdown
Member Author

@ldemailly ldemailly Jun 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it references local files like

 - [Writing Mixer adapters](./adapters.md)

(hard to spot in the sea of red but it's there)
so I don't think we should do that

@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Jun 1, 2017

please re-review/accept - tia

@ldemailly ldemailly merged commit ca58f01 into master Jun 1, 2017
@ldemailly ldemailly deleted the ldemailly_devel_docs branch June 1, 2017 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xiaolanz xiaolanz Awaiting requested review from xiaolanz

1 more reviewer

@geeknoid geeknoid geeknoid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ldemailly @istio-testing @geeknoid @googlebot