Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

Dependency Hoisting and istio.deps#89

Closed
chxchx wants to merge 1 commit intoistio:masterfrom
chxchx:deps
Closed

Dependency Hoisting and istio.deps#89
chxchx wants to merge 1 commit intoistio:masterfrom
chxchx:deps

Conversation

@chxchx
Copy link
Copy Markdown

@chxchx chxchx commented Jul 27, 2017

@sebastienvas @yutongz PTAL

This change is required for auto upates on dependency. If this looks good to you, I will roll out similar changes to the rest of istio repositories.

@istio-testing
Copy link
Copy Markdown
Contributor

Jenkins job mixerclient/presubmit passed

@sebastienvas
Copy link
Copy Markdown
Contributor

Could you acutally start with istio/istio ?

@chxchx
Copy link
Copy Markdown
Author

chxchx commented Jul 27, 2017

Actually, changes similar to the ones in this PR are meant to be applied to other repos under istio project except istio/istio. In istio/istio, the install/updateVersion.sh script is required to update istio.VERSION file, and in order to use its command-line flags properly, the set of dependencies has to be hard coded in the update-deps script in some way. We could roll out the deps update feature by starting with istio/istio, but no additional files are necessary besides running the update-deps binary and specifing istio as target repo. Is this how I should proceed?

@istio-testing
Copy link
Copy Markdown
Contributor

Jenkins job mixerclient/presubmit passed

@istio-testing
Copy link
Copy Markdown
Contributor

Jenkins job mixerclient/presubmit passed

@chxchx chxchx closed this Jul 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants