This repository was archived by the owner on Jun 14, 2018. It is now read-only.
istioctl: use --tag/--hub instead --initImage/--runtimeImage#388
Merged
ayj merged 6 commits intoistio:masterfrom Mar 24, 2017
Merged
istioctl: use --tag/--hub instead --initImage/--runtimeImage#388ayj merged 6 commits intoistio:masterfrom
ayj merged 6 commits intoistio:masterfrom
Conversation
Use --tag and --hub instead of --initImage and --runtimeImage flags. This makes usage a bit more concise because the hub is unlikely to change and the tag is common between init and runtime image. Furthermore, it is consistent with the manager integration test flags.
kyessenov
reviewed
Mar 24, 2017
platform/kube/inject/inject.go
Outdated
| DefaultInitImage = "docker.io/istio/init:latest" | ||
| DefaultRuntimeImage = "docker.io/istio/runtime:latest" | ||
| DefaultHub = "docker.io" | ||
| DefaultTag = "2017-03-22-17.30.06" |
Contributor
There was a problem hiding this comment.
Maybe use build version here?
Contributor
Author
There was a problem hiding this comment.
That would work, but maybe we should wait until we have full acceptance test in place which verifies latest version of manager, proxy, and mixer together with a matching version of istioctl?
…ag-and-change-defaults
kyessenov
approved these changes
Mar 24, 2017
Contributor
|
Jenkins job manager/presubmit passed |
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 64.85% 64.88% +0.02%
==========================================
Files 25 25
Lines 2632 2634 +2
==========================================
+ Hits 1707 1709 +2
Misses 800 800
Partials 125 125
Continue to review full report at Codecov.
|
…ag-and-change-defaults
Contributor
|
Jenkins job manager/presubmit passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use --tag and --hub instead of --initImage and --runtimeImage flags.
This makes usage a bit more concise because the hub is unlikely to
change and the tag is common between init and runtime image.
Furthermore, it is consistent with the manager integration test flags.