Skip to content

update rbac api version to rbac.istio.io/v1alpha1.#1879

Merged
istio-testing merged 1 commit intoistio:masterfrom
yangminzhu:update_rbac
Jul 18, 2018
Merged

update rbac api version to rbac.istio.io/v1alpha1.#1879
istio-testing merged 1 commit intoistio:masterfrom
yangminzhu:update_rbac

Conversation

@yangminzhu
Copy link
Copy Markdown
Contributor

align with istio/istio#6874

/cc @ymesika

@istio-testing istio-testing requested a review from ymesika July 18, 2018 21:25
@yangminzhu yangminzhu requested review from frankbu and removed request for jasminejaksic July 18, 2018 21:29
Copy link
Copy Markdown
Contributor

@liminw liminw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sdake
Copy link
Copy Markdown
Member

sdake commented Jul 18, 2018

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liminw, sdake, yangminzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 0b9e3ab into istio:master Jul 18, 2018
@yangminzhu yangminzhu deleted the update_rbac branch July 18, 2018 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants