Skip to content

[test-framework] Refactoring local application and agent#8809

Merged
hklai merged 1 commit intoistio:masterfrom
nmittler:mixer
Sep 18, 2018
Merged

[test-framework] Refactoring local application and agent#8809
hklai merged 1 commit intoistio:masterfrom
nmittler:mixer

Conversation

@nmittler
Copy link
Copy Markdown
Contributor

This code has gotten pretty nested and hard to wade through. Moving
things around and cleaning up some naming to make the code more clear.

This code has gotten pretty nested and hard to wade through. Moving
things around and cleaning up some naming to make the code more clear.
@nmittler nmittler requested a review from ozevren September 18, 2018 18:02
@nmittler nmittler removed the request for review from geeknoid September 18, 2018 18:02
@nmittler
Copy link
Copy Markdown
Contributor Author

/test e2e-bookInfo-envoyv2-v1alpha3

1 similar comment
@nmittler
Copy link
Copy Markdown
Contributor Author

/test e2e-bookInfo-envoyv2-v1alpha3

@ozevren
Copy link
Copy Markdown
Contributor

ozevren commented Sep 18, 2018

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

@nmittler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-bookInfoTests-v1alpha3.sh 7607496 link /test e2e-bookInfo-envoyv2-v1alpha3
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler
Copy link
Copy Markdown
Contributor Author

@costinm mind manually merging this? It's blocked by a failing test on prow .... this is just moving things around in the test framework.

@hklai hklai merged commit 6afefef into istio:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants