Update Proxy SHA to latest with reverted TCP proxy changes (release-1.0).#8389
Merged
costinm merged 1 commit intoistio:release-1.0from Aug 31, 2018
Merged
Conversation
….0). Pulling the following changes from github.com/istio/proxy: 99cfc3f Update Envoy SHA to latest with reverted TCP proxy changes (release-1.0). (istio#1956) Pulling the following changes from github.com/istio/envoy: 2d8386532 Disable broken thrift_proxy tests for TCP connection pool. 828847db1 Revert "tcp_proxy: convert TCP proxy to use TCP connection pool (istio#4067)" Fixes istio#8310. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
Author
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: costinm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulling the following changes from github.com/istio/proxy:
99cfc3f Update Envoy SHA to latest with reverted TCP proxy changes (release-1.0). (#1956)
Pulling the following changes from github.com/istio/envoy:
2d8386532 Disable broken thrift_proxy tests for TCP connection pool.
828847db1 Revert "tcp_proxy: convert TCP proxy to use TCP connection pool (#4067)"
Fixes #8310.
Signed-off-by: Piotr Sikora piotrsikora@google.com