Skip to content

Redo #5957 in master as it was removed during merge from release-1.0.#8285

Merged
rshriram merged 1 commit intoistio:masterfrom
hklai:circle_patch
Aug 27, 2018
Merged

Redo #5957 in master as it was removed during merge from release-1.0.#8285
rshriram merged 1 commit intoistio:masterfrom
hklai:circle_patch

Conversation

@hklai
Copy link
Copy Markdown
Contributor

@hklai hklai commented Aug 27, 2018

No description provided.

@hklai hklai requested review from costinm and kyessenov August 27, 2018 21:55
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Aug 27, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai

If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Aug 27, 2018

@hklai: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh 1ee00c0 link /test istio-unit-tests
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram rshriram merged commit b865c6b into istio:master Aug 27, 2018
@hklai hklai deleted the circle_patch branch September 19, 2018 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costinm costinm Awaiting requested review from costinm costinm is a code owner

@kyessenov kyessenov Awaiting requested review from kyessenov

@ZackButcher ZackButcher Awaiting requested review from ZackButcher

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hklai @istio-testing @rshriram @googlebot