Skip to content

update proxy/api sha in collab-gcp-identity#8137

Merged
istio-testing merged 7 commits intoistio:collab-gcp-identityfrom
quanjielin:quanlinproxysha1
Aug 23, 2018
Merged

update proxy/api sha in collab-gcp-identity#8137
istio-testing merged 7 commits intoistio:collab-gcp-identityfrom
quanjielin:quanlinproxysha1

Conversation

@quanjielin
Copy link
Copy Markdown
Contributor

@quanjielin quanjielin commented Aug 22, 2018 •
edited
Loading

since the proxy SHA contains latest change, cherrypick #8087, #8052 from master to make mixer test pass.

@quanjielin
Copy link
Copy Markdown
Contributor Author

quanjielin commented Aug 22, 2018

verified e2e works

/cc @wattli @qiwzhang @JimmyCYJ

@quanjielin quanjielin added the do-not-merge/hold Block automatic merging of a PR. label Aug 22, 2018
@quanjielin
Copy link
Copy Markdown
Contributor Author

quanjielin commented Aug 22, 2018

seems proxy image is a bit old, causes mixer test fail - https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8137/istio-unit-tests/12053/

ex, Failed to verify OKGet report: attribute context.proxy_error_code is expected , proxy_error_code is checked in by istio/proxy#1897

@quanjielin
Copy link
Copy Markdown
Contributor Author

quanjielin commented Aug 23, 2018

/test e2e-mixer-no_auth
/test e2e-dashboard
/test istio-unit-tests
/test e2e-bookInfo-envoyv2-v1alpha3

@quanjielin
Copy link
Copy Markdown
Contributor Author

quanjielin commented Aug 23, 2018

@kyessenov, the proxy sha in this PR(built by @JimmyCYJ ) should contains istio/proxy#1897, but mixer test error Failed to verify OKGet report: attribute context.proxy_error_code is expected , proxy_error_code seems indicate the change on istio.deps isn't picked up ? do you know how to tell which proxy sha used in PR test ?

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 23, 2018 •
edited
Loading

Codecov Report

Merging #8137 into collab-gcp-identity will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           collab-gcp-identity   #8137    +/-   ##
====================================================
- Coverage                   71%     71%   -<1%     
====================================================
  Files                      377     377            
  Lines                    33136   33218    +82     
====================================================
+ Hits                     23259   23272    +13     
- Misses                    8825    8889    +64     
- Partials                  1052    1057     +5
Impacted Files Coverage Δ
mixer/adapter/rbac/controller.go 29% <0%> (-24%) ⬇️
mixer/adapter/cloudwatch/cloudwatch.go 58% <0%> (-14%) ⬇️
mixer/adapter/solarwinds/metrics_handler.go 70% <0%> (-13%) ⬇️
pilot/pkg/config/memory/monitor.go 82% <0%> (-9%) ⬇️
security/pkg/nodeagent/cache/secretcache.go 72% <0%> (-4%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 84% <0%> (-1%) ⬇️
pilot/pkg/model/push_context.go 7% <0%> (-1%) ⬇️
mixer/adapter/servicecontrol/quotaprocessor.go 83% <0%> (ø) ⬇️
istioctl/cmd/istioctl/main.go 34% <0%> (ø) ⬇️
mixer/adapter/rbac/rbac.go 11% <0%> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb7dfc...9c99624. Read the comment docs.

@quanjielin quanjielin changed the title update proxy sha update proxy/api sha in collab-gcp-identity branch Aug 23, 2018
@quanjielin quanjielin changed the title update proxy/api sha in collab-gcp-identity branch update proxy/api sha in collab-gcp-identity Aug 23, 2018
@ldemailly ldemailly removed their request for review August 23, 2018 19:49
@quanjielin
Copy link
Copy Markdown
Contributor Author

quanjielin commented Aug 23, 2018

/cc @hklai @rkpagadala - This is the PR to update proxy/api SHA in gcp-identity

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Aug 23, 2018

@quanjielin: GitHub didn't allow me to request PR reviews from the following users: -, is, the, to, update, SHA, This, PR, proxy/api, in.

Note that only istio members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @hklai @rkpagadala - This is the PR to update proxy/api SHA in gcp-identity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@quanjielin quanjielin removed the do-not-merge/hold Block automatic merging of a PR. label Aug 23, 2018
wattli
wattli approved these changes Aug 23, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@wattli wattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Aug 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wattli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit c1551ba into istio:collab-gcp-identity Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandarjog mandarjog Awaiting requested review from mandarjog

@JimmyCYJ JimmyCYJ Awaiting requested review from JimmyCYJ

@qiwzhang qiwzhang Awaiting requested review from qiwzhang

@hklai hklai Awaiting requested review from hklai

@rkpagadala rkpagadala Awaiting requested review from rkpagadala

1 more reviewer

@wattli wattli wattli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wattli wattli

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@quanjielin @istio-testing @wattli @googlebot @bianpengyuan