Skip to content

Revert " Merge branch 'release-1.0' into 'collab-gcp-identity' (#7305)"#8011

Merged
incfly merged 1 commit intoistio:collab-gcp-identityfrom
incfly:collab-gcp-identity
Aug 17, 2018
Merged

Revert " Merge branch 'release-1.0' into 'collab-gcp-identity' (#7305)"#8011
incfly merged 1 commit intoistio:collab-gcp-identityfrom
incfly:collab-gcp-identity

Conversation

@incfly
Copy link
Copy Markdown

@incfly incfly commented Aug 17, 2018

Reverts #7305

Step 1 for #8009

@incfly incfly force-pushed the collab-gcp-identity branch from 522a773 to 273c322 Compare August 17, 2018 17:29
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 17, 2018

Codecov Report

Merging #8011 into collab-gcp-identity will increase coverage by 1%.
The diff coverage is 40%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           collab-gcp-identity   #8011    +/-   ##
====================================================
+ Coverage                   72%     72%    +1%     
====================================================
  Files                      359     358     -1     
  Lines                    30781   30405   -376     
====================================================
- Hits                     21874   21671   -203     
+ Misses                    7952    7789   -163     
+ Partials                   955     945    -10
Impacted Files Coverage Δ
mixer/adapter/redisquota/redisquota.go 88% <ø> (-2%) ⬇️
mixer/pkg/lang/ast/func.go 100% <ø> (ø) ⬆️
mixer/pkg/il/opcode.go 100% <ø> (ø) ⬆️
pilot/pkg/kube/inject/inject.go 85% <ø> (+1%) ⬆️
mixer/pkg/il/builder.go 100% <ø> (ø) ⬆️
galley/pkg/runtime/resource/types.go 100% <ø> (ø) ⬆️
mixer/pkg/lang/compiler/compiler.go 90% <ø> (-3%) ⬇️
mixer/pkg/config/crd/init.go 0% <0%> (ø) ⬆️
istioctl/cmd/istioctl/gendeployment/cmd.go 30% <0%> (ø) ⬆️
pilot/pkg/config/kube/ingress/controller.go 0% <0%> (ø) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc73818...273c322. Read the comment docs.

Copy link
Copy Markdown
Contributor

@quanjielin quanjielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kyessenov

If they are not already assigned, you can assign the PR to them by writing /assign @kyessenov in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly incfly merged commit 4c4db21 into istio:collab-gcp-identity Aug 17, 2018
@incfly incfly deleted the collab-gcp-identity branch September 13, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants