Skip to content

Update bookinfo code (#6988)#7151

Closed
vadimeisenbergibm wants to merge 1 commit intoistio:masterfrom
vadimeisenbergibm:submit_6988_to_master
Closed

Update bookinfo code (#6988)#7151
vadimeisenbergibm wants to merge 1 commit intoistio:masterfrom
vadimeisenbergibm:submit_6988_to_master

Conversation

@vadimeisenbergibm
Copy link
Copy Markdown
Contributor

This is submission of #6898 (a PR to release-1.0) to master.

* WITH_ISTIO -> DO_NOT_USE_TLS_FOR_EXTERNAL_SERVICE_CALLS

Istio now can handle HTTPS (originated by the application). The decision
to use HTTP or HTTPS now is unrelated to the fact that the appliation
runs with Istio or without it.

* set DO_NOT_USE_TLS_FOR_EXTERNAL_SERVICE_CALLS to true for details v2

* return a yaml separator

* remove redundant dash

* DO_NOT_USE_TLS_FOR_EXTERNAL_SERVICE_CALLS -> DO_NOT_ENCRYPT

* rephrase comments about DO_NOT_ENCRYPT

* replace niaquinto/gradle with library/gradle

niaquinto/gradle has been removed from docker

* Use new bookinfo

* Switch back to standard ratings image
* Remove unneeded file name
* Update Writer flush in productpage.py
* Allow services domain to be configurable
* This is needed to run on CloudFoundry

* update bookinfo images to 1.7.0 version

* lock the mysql docker image version

* use the previous version of the mysqldb image

due to an issue with the updated mysql version, fixed in the previous commit
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vadimeisenbergibm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadimeisenbergibm lets not merge individual changes into master. This makes it very very hard to merge the release-1.0 branch back into master. I asked the other user to rebase against release-1.0 branch

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 16, 2018

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-simpleTests.sh 3e3533f link /test e2e-simple
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vadimeisenbergibm
Copy link
Copy Markdown
Contributor Author

@rshriram OK, understood, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants