Skip to content

remove MeshPolicy/DefaultDestRule CRD when mTLS isn't enabled#7017

Merged
rshriram merged 1 commit intoistio:release-1.0from
quanjielin:quanlincrd2
Jul 11, 2018
Merged

remove MeshPolicy/DefaultDestRule CRD when mTLS isn't enabled#7017
rshriram merged 1 commit intoistio:release-1.0from
quanjielin:quanlincrd2

Conversation

@quanjielin
Copy link
Copy Markdown
Contributor

@quanjielin quanjielin commented Jul 11, 2018

No description provided.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 11, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson

Assign the PR to them by writing /assign @greghanson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing requested review from sbezverk and sdake July 11, 2018 17:03
@quanjielin quanjielin removed request for sbezverk and sdake July 11, 2018 17:03
rshriram
rshriram reviewed Jul 11, 2018
View reviewed changes
install/kubernetes/helm/istio/charts/security/templates/configmap.yaml
{{- include "security-default.yaml.tpl" . | indent 4}}
{{- if .Values.global.mtls.enabled }}
{{- include "security-default.yaml.tpl" . | indent 4}}
{{- end }}
Copy link
Copy Markdown
Member

@rshriram rshriram Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this is confusing, I don't think this is causing any issue. Make sure that the run.sh stuff below still works

Copy link
Copy Markdown
Contributor Author

@quanjielin quanjielin Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this need to be fixed though no scenario is broken for now(btw, integration test pass)

@quanjielin quanjielin requested a review from ayj July 11, 2018 17:51
@rshriram rshriram merged commit 8f334e4 into istio:release-1.0 Jul 11, 2018
@quanjielin quanjielin mentioned this pull request Jul 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayj ayj Awaiting requested review from ayj

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@quanjielin @istio-testing @rshriram @googlebot