Skip to content

update the istio.io/api SHA (https://github.com/istio/api/pull/575) and istio.io/proxy SHA#6997

Merged
hklai merged 1 commit intoistio:release-1.0from
vadimeisenbergibm:update_api_sha_294a445476f816ec90e2a6fe2d67968c9d322649
Jul 11, 2018
Merged

update the istio.io/api SHA (https://github.com/istio/api/pull/575) and istio.io/proxy SHA#6997
hklai merged 1 commit intoistio:release-1.0from
vadimeisenbergibm:update_api_sha_294a445476f816ec90e2a6fe2d67968c9d322649

Conversation

@vadimeisenbergibm
Copy link
Copy Markdown
Contributor

No description provided.

@vadimeisenbergibm vadimeisenbergibm requested a review from hklai July 11, 2018 03:46
@vadimeisenbergibm vadimeisenbergibm changed the title update the istio.io/api SHA (https://github.com/istio/api/pull/575) [WIP] update the istio.io/api SHA (https://github.com/istio/api/pull/575) and istio.io/proxy SHA Jul 11, 2018
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 11, 2018
@vadimeisenbergibm vadimeisenbergibm changed the title [WIP] update the istio.io/api SHA (https://github.com/istio/api/pull/575) and istio.io/proxy SHA update the istio.io/api SHA (https://github.com/istio/api/pull/575) and istio.io/proxy SHA Jul 11, 2018
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 11, 2018
@vadimeisenbergibm
Copy link
Copy Markdown
Contributor Author

@hklai I see that the dependency on istio/proxy is usually updated automatically, by a robot executing https://github.com/istio/test-infra/blob/master/prow/test-infra-update-deps.sh. If so, only the dependency of istio/api must be updated. Could you please merge this PR? Or should I update the istio/proxy dependency manually?

Copy link
Copy Markdown
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, vadimeisenbergibm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai hklai merged commit 99668ea into istio:release-1.0 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants