Skip to content

Move mixer rules under policy and rename route-rule to virtual-service#6940

Merged
costinm merged 5 commits intorelease-1.0from
book
Jul 9, 2018
Merged

Move mixer rules under policy and rename route-rule to virtual-service#6940
costinm merged 5 commits intorelease-1.0from
book

Conversation

@andraxylia
Copy link
Copy Markdown
Contributor

@andraxylia andraxylia commented Jul 9, 2018 •
edited
Loading

Corresponding doc changes in istio/istio.io#1715

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 9, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andraxylia
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

Assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2018 •
edited
Loading

Codecov Report

Merging #6940 into release-1.0 will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.0   #6940    +/-   ##
============================================
- Coverage           71%     71%   -<1%     
============================================
  Files              360     360            
  Lines            31317   31044   -273     
============================================
- Hits             22169   21904   -265     
  Misses            8272    8272            
+ Partials           876     868     -8
Impacted Files Coverage Δ
mixer/adapter/solarwinds/metrics_handler.go 70% <0%> (-13%) ⬇️
mixer/adapter/signalfx/cumulative.go 67% <0%> (-4%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 66% <0%> (-2%) ⬇️
mixer/adapter/redisquota/redisquota.go 88% <0%> (-2%) ⬇️
mixer/adapter/prometheus/server.go 95% <0%> (-1%) ⬇️
mixer/adapter/bypass/bypass.go 62% <0%> (-1%) ⬇️
mixer/adapter/statsd/statsd.go 96% <0%> (-1%) ⬇️
mixer/adapter/bypass/util.go 7% <0%> (ø) ⬇️
mixer/pkg/config/crd/store.go 99% <0%> (ø) ⬇️
mixer/adapter/cloudwatch/handler.go 87% <0%> (ø) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee51c9...a08518d. Read the comment docs.

douglas-reid
douglas-reid reviewed Jul 9, 2018
View reviewed changes
tests/e2e/tests/mixer/mixer_test.go Outdated
productPageTimeout = 60 * time.Second

rulesDir = "kube" // v1 rules directory by default
rulesDir = "policy"
Copy link
Copy Markdown
Contributor

@douglas-reid douglas-reid Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i feel like by splitting policy rules from networking you will need to update logic here for the files below ( routeAllRule, routeReviewsVersionsRules, routeReviewsV3Rule, tcpDbRule, bookinfo-gateway).

Were you able to run this locally successfully?

Copy link
Copy Markdown
Contributor Author

@andraxylia andraxylia Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@andraxylia andraxylia changed the title Move mixer rules under policy Move mixer rules under policy and rename route-rule to virtual-service Jul 9, 2018
@andraxylia andraxylia mentioned this pull request Jul 9, 2018
Merged
@andraxylia
Copy link
Copy Markdown
Contributor Author

andraxylia commented Jul 9, 2018

@costinm @rshriram @hklai need approval for bookinfo changes

@costinm costinm merged commit 79289bc into release-1.0 Jul 9, 2018
@andraxylia andraxylia deleted the book branch July 10, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costinm costinm costinm approved these changes

@frankbu frankbu Awaiting requested review from frankbu

@sebastienvas sebastienvas Awaiting requested review from sebastienvas

@rshriram rshriram Awaiting requested review from rshriram

+1 more reviewer

@douglas-reid douglas-reid douglas-reid left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andraxylia @istio-testing @costinm @douglas-reid @googlebot