Move dump_kubernetes.sh to tools/ (gets copied to istio-archive)#6938
Move dump_kubernetes.sh to tools/ (gets copied to istio-archive)#6938mandarjog merged 3 commits intoistio:release-1.0from Tahler:dump-k8s-in-release
Conversation
|
I wonder if this would be better placed in tools? Probably less confusing for the general Istio customer if the script isn't the only thing next to |
|
I agree, lets move it to tools/* in archive. Can you submit this PR on release-1.0 ? |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #6938 +/- ##
============================================
+ Coverage 71% 71% +1%
============================================
Files 360 360
Lines 31317 31134 -183
============================================
- Hits 22169 22059 -110
+ Misses 8272 8208 -64
+ Partials 876 867 -9
Continue to review full report at Codecov.
|
|
It was actually easier to just move the dump script to tools/, since that entire directory gets copied. I'll update the wiki page to reflect the new script location once this PR goes in. |
|
What about circleci changes that call this script? |
|
Good call. Done. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandarjog, Tahler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Confirmed by running
make istio-archive.