Skip to content

Move dump_kubernetes.sh to tools/ (gets copied to istio-archive)#6938

Merged
mandarjog merged 3 commits intoistio:release-1.0from
Tahler:dump-k8s-in-release
Jul 10, 2018
Merged

Move dump_kubernetes.sh to tools/ (gets copied to istio-archive)#6938
mandarjog merged 3 commits intoistio:release-1.0from
Tahler:dump-k8s-in-release

Conversation

@Tahler
Copy link
Copy Markdown
Contributor

@Tahler Tahler commented Jul 9, 2018

Confirmed by running make istio-archive.

@Tahler Tahler requested a review from mandarjog July 9, 2018 21:15
@istio-testing istio-testing requested review from chxchx and yutongz July 9, 2018 21:15
@Tahler
Copy link
Copy Markdown
Contributor Author

Tahler commented Jul 9, 2018

I wonder if this would be better placed in tools? Probably less confusing for the general Istio customer if the script isn't the only thing next to bin/istioctl.
@mandarjog @costinm

@mandarjog
Copy link
Copy Markdown
Contributor

I agree, lets move it to tools/* in archive.
It should also go into tools in the source code though, but that can happen later.

Can you submit this PR on release-1.0 ?

@Tahler Tahler changed the base branch from master to release-1.0 July 9, 2018 21:41
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2018

Codecov Report

Merging #6938 into release-1.0 will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.0   #6938    +/-   ##
============================================
+ Coverage           71%     71%    +1%     
============================================
  Files              360     360            
  Lines            31317   31134   -183     
============================================
- Hits             22169   22059   -110     
+ Misses            8272    8208    -64     
+ Partials           876     867     -9
Impacted Files Coverage Δ
mixer/adapter/rbac/controller.go 29% <0%> (-24%) ⬇️
mixer/adapter/signalfx/signalfx.go 82% <0%> (-2%) ⬇️
mixer/adapter/prometheus/server.go 95% <0%> (-1%) ⬇️
mixer/adapter/bypass/bypass.go 62% <0%> (-1%) ⬇️
mixer/adapter/statsd/statsd.go 96% <0%> (-1%) ⬇️
mixer/adapter/bypass/util.go 7% <0%> (ø) ⬇️
mixer/pkg/config/crd/store.go 99% <0%> (ø) ⬇️
mixer/adapter/cloudwatch/handler.go 87% <0%> (ø) ⬇️
mixer/pkg/protobuf/yaml/pool.go 100% <0%> (ø) ⬆️
pilot/pkg/model/controller.go 100% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee51c9...9388d12. Read the comment docs.

@Tahler
Copy link
Copy Markdown
Contributor Author

Tahler commented Jul 9, 2018

It was actually easier to just move the dump script to tools/, since that entire directory gets copied. I'll update the wiki page to reflect the new script location once this PR goes in.

@Tahler Tahler changed the title Include dump_kubernetes.sh in release archive bin dir Move dump_kubernetes.sh to tools/ (gets copied to istio-archive) Jul 9, 2018
@mandarjog
Copy link
Copy Markdown
Contributor

What about circleci changes that call this script?

@Tahler
Copy link
Copy Markdown
Contributor Author

Tahler commented Jul 9, 2018

Good call. Done.

@mandarjog
Copy link
Copy Markdown
Contributor

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandarjog, Tahler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog mandarjog merged commit f622e9c into istio:release-1.0 Jul 10, 2018
@Tahler Tahler deleted the dump-k8s-in-release branch July 10, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants