Delete namespace after tests when using helm#6919
Delete namespace after tests when using helm#6919alex-slynko wants to merge 2 commits intoistio:masterfrom
Conversation
Signed-off-by: Neil Hickey <nhickey@pivotal.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alex-slynko Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
/ok-to-test |
tests/e2e/framework/kubernetes.go
Outdated
|
|
||
| if err := util.DeleteNamespace(k.Namespace, k.KubeConfig); err != nil { | ||
| log.Errorf("Failed to delete namespace %s", k.Namespace) | ||
| return err |
There was a problem hiding this comment.
Might not want to return err here. If the helm chart being deleted has the namespace manifest then the HelmDelete step would delete the ns and this DeleteNamespace would fail since the ns is already gone. In that case propagating the err from the Teardown method would be an issue.
|
Fixes #6700 |
|
PR to release-1.0 branch |
|
@rshriram do I have to PR to both master and release branch? |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
If the helm chart being deleted has the namespace manifest then the HelmDelete would've already deleted the namespace
|
closed in favor of #7051 that is opened against release-1.0 branch |
Signed-off-by: Neil Hickey nhickey@pivotal.io