Skip to content

Correcting duplication of annotations field in values.yaml#6914

Merged
rshriram merged 1 commit intoistio:release-1.0from
ymesika:duplicatedAnnotations
Jul 8, 2018
Merged

Correcting duplication of annotations field in values.yaml#6914
rshriram merged 1 commit intoistio:release-1.0from
ymesika:duplicatedAnnotations

Conversation

@ymesika
Copy link
Copy Markdown
Member

@ymesika ymesika commented Jul 8, 2018

The duplication causes an error when using the script that auto-generates the docs table of possible installation options.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 8, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ymesika
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gyliu513

Assign the PR to them by writing /assign @gyliu513 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 8, 2018 •
edited
Loading

Codecov Report

Merging #6914 into release-1.0 will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.0   #6914    +/-   ##
============================================
- Coverage           71%     71%   -<1%     
============================================
  Files              370     370            
  Lines            31862   31965   +103     
============================================
+ Hits             22463   22532    +69     
- Misses            8492    8529    +37     
+ Partials           907     904     -3
Impacted Files Coverage Δ
mixer/adapter/cloudwatch/cloudwatch.go 58% <0%> (-14%) ⬇️
mixer/adapter/servicecontrol/handler.go 39% <0%> (-8%) ⬇️
mixer/adapter/servicecontrol/reportprocessor.go 73% <0%> (-7%) ⬇️
broker/pkg/controller/controller.go 34% <0%> (-5%) ⬇️
...olarwinds/internal/papertrail/papertrail_logger.go 59% <0%> (-3%) ⬇️
mixer/adapter/circonus/circonus.go 71% <0%> (ø) ⬇️
mixer/adapter/list/regexList.go 100% <0%> (ø) ⬆️
mixer/adapter/stdio/stdio.go 100% <0%> (ø) ⬆️
mixer/adapter/list/ipList.go 100% <0%> (ø) ⬆️
mixer/adapter/memquota/memquota.go 100% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3374582...382ed70. Read the comment docs.

@rshriram rshriram merged commit 7c964ec into istio:release-1.0 Jul 8, 2018
@ymesika ymesika deleted the duplicatedAnnotations branch July 9, 2018 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregHanson GregHanson Awaiting requested review from GregHanson

@linsun linsun Awaiting requested review from linsun

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ymesika @istio-testing @rshriram @googlebot