Skip to content

Remove the post-install hooks when they were completed successfully#6911

Merged
rshriram merged 1 commit intoistio:release-1.0from
ymesika:removeCompletedPostInstalls
Jul 8, 2018
Merged

Remove the post-install hooks when they were completed successfully#6911
rshriram merged 1 commit intoistio:release-1.0from
ymesika:removeCompletedPostInstalls

Conversation

@ymesika
Copy link
Copy Markdown
Member

@ymesika ymesika commented Jul 8, 2018

An installation of Istio with mTLS enabled will result in the following state:

NAME                                       READY     STATUS      RESTARTS   AGE
istio-citadel-85fcc767fc-wpz5q             1/1       Running     0          1m
istio-egressgateway-867bc6b594-2shzs       1/1       Running     0          1m
istio-galley-5f5f9b9676-2q7zs              1/1       Running     0          1m
istio-ingress-787bb7c94b-zpxrz             1/1       Running     0          1m
istio-ingressgateway-6df8678998-6bgjh      1/1       Running     0          1m
istio-mixer-post-install-rfwxk             0/1       Completed   0          1m
istio-pilot-6db8d59464-zdj55               2/2       Running     0          1m
istio-policy-7b978cf7df-dc596              2/2       Running     0          1m
istio-security-post-install-vzlx4          0/1       Completed   0          51s
istio-sidecar-injector-855f88c954-p6lkp    1/1       Running     0          1m
istio-statsd-prom-bridge-59b45fd6d-kfk86   1/1       Running     0          1m
istio-telemetry-7dfcc797b6-hnvnh           2/2       Running     0          1m
prometheus-ffd95f9f6-fcmrj                 1/1       Running     0          1m

Although completed, the Mixer and Security post-install jobs are lingering until next install.
This PR remove them upon successful completion leaving the environment a bit cleaner.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 8, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ymesika
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun

Assign the PR to them by writing /assign @linsun in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing requested review from ostromart and sdake July 8, 2018 10:37
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 8, 2018 •
edited
Loading

Codecov Report

Merging #6911 into release-1.0 will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.0   #6911    +/-   ##
============================================
+ Coverage           71%     71%    +1%     
============================================
  Files              370     370            
  Lines            31862   31721   -141     
============================================
- Hits             22463   22387    -76     
+ Misses            8492    8435    -57     
+ Partials           907     899     -8
Impacted Files Coverage Δ
mixer/adapter/cloudwatch/cloudwatch.go 58% <0%> (-14%) ⬇️
pilot/pkg/config/memory/monitor.go 82% <0%> (-9%) ⬇️
mixer/adapter/servicecontrol/handler.go 39% <0%> (-8%) ⬇️
mixer/adapter/bypass/util.go 5% <0%> (-1%) ⬇️
mixer/adapter/kubernetesenv/cache.go 91% <0%> (-1%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 66% <0%> (ø) ⬇️
mixer/adapter/stackdriver/contextgraph/workload.go 75% <0%> (ø) ⬇️
mixer/adapter/circonus/circonus.go 71% <0%> (ø) ⬇️
mixer/adapter/cloudwatch/client.go 0% <0%> (ø) ⬆️
mixer/adapter/list/regexList.go 100% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3374582...cdfc4fa. Read the comment docs.

@rshriram rshriram merged commit 2fd7fb5 into istio:release-1.0 Jul 8, 2018
@ymesika ymesika deleted the removeCompletedPostInstalls branch July 9, 2018 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ostromart ostromart Awaiting requested review from ostromart

@sdake sdake Awaiting requested review from sdake

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ymesika @istio-testing @rshriram @googlebot