[WIP] Refactor RBAC crds's group name#6820
[WIP] Refactor RBAC crds's group name#6820ymesika wants to merge 8 commits intoistio:masterfrom ymesika:rbacRefactor
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ymesika Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6820 +/- ##
=======================================
- Coverage 71% 71% -<1%
=======================================
Files 369 369
Lines 31907 31729 -178
=======================================
- Hits 22420 22231 -189
- Misses 8574 8577 +3
- Partials 913 921 +8
Continue to review full report at Codecov.
|
|
@ymesika: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| apiVersion = "v1alpha2" | ||
| apiGroupVersion = apiGroup + "/" + apiVersion | ||
| ) | ||
|
|
There was a problem hiding this comment.
@douglas-reid / @geeknoid et al was there any reason to have this in a generic config.istio.io instead of .istio.io ?
|
Replaced by #6874 with |
|
An approach like this can help support old and new API Groups side-by-side: This is not tested, and still not complete enough to help with the RBAC case. For that, I think the right model would be to pass the full APIGroup/Version/Kind information instead of simply kinds. |
Refactor the CRD group names of the RBAC related resources from
config.istio.io/v1alpha2torbac.istio.io/v1alpha2.cc @rshriram