Skip to content

fix bug so that destination.service.** attributes are collected#6819

Merged
costinm merged 1 commit intoistio:release-1.0from
quanjielin:quanlinattr1
Jul 3, 2018
Merged

fix bug so that destination.service.** attributes are collected#6819
costinm merged 1 commit intoistio:release-1.0from
quanjielin:quanlinattr1

Conversation

@quanjielin
Copy link
Copy Markdown
Contributor

check in #6801 to 1.0 branch

@quanjielin quanjielin requested review from kyessenov and removed request for mandarjog July 3, 2018 16:18
@quanjielin
Copy link
Copy Markdown
Contributor Author

/cc @rkpagadala

Copy link
Copy Markdown
Contributor

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hklai hklai requested a review from costinm July 3, 2018 19:26
Copy link
Copy Markdown
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Will have @costin for another pair of eyes before merging.

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglas-reid, hklai, quanjielin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm costinm merged commit 344ed1f into istio:release-1.0 Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants