Skip to content

[WIP] e2e multicluster test combined PR set #6639

Closed
tiswanso wants to merge 17 commits intoistio:masterfrom
tiswanso:multiclus_test_fixeps2
Closed

[WIP] e2e multicluster test combined PR set #6639
tiswanso wants to merge 17 commits intoistio:masterfrom
tiswanso:multiclus_test_fixeps2

Conversation

@tiswanso
Copy link
Copy Markdown
Contributor

@tiswanso tiswanso commented Jun 26, 2018

Using this PR to test several PRs together for multicluster.

Testing the following PRs together
#5516
#6454
#6679

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 26, 2018
@tiswanso
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-multicluster-e2e

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2018

Codecov Report

Merging #6639 into master will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #6639    +/-   ##
=======================================
+ Coverage      71%     71%    +1%     
=======================================
  Files         368     366     -2     
  Lines       31874   31388   -486     
=======================================
- Hits        22455   22149   -306     
+ Misses       8490    8352   -138     
+ Partials      929     887    -42
Impacted Files Coverage Δ
pilot/pkg/networking/core/v1alpha3/configgen.go 0% <0%> (-100%) ⬇️
pilot/pkg/config/aggregate/config.go 0% <0%> (-79%) ⬇️
pilot/pkg/networking/core/v1alpha3/cluster.go 0% <0%> (-38%) ⬇️
pilot/pkg/config/memory/monitor.go 82% <0%> (-9%) ⬇️
mixer/adapter/signalfx/cumulative.go 67% <0%> (-4%) ⬇️
mixer/adapter/statsd/statsd.go 96% <0%> (-1%) ⬇️
pilot/pkg/model/conversion.go 89% <0%> (ø) ⬇️
mixer/adapter/cloudwatch/handler.go 87% <0%> (ø) ⬇️
pilot/pkg/model/context.go 65% <0%> (ø) ⬇️
pilot/pkg/networking/core/v1alpha3/httproute.go 24% <0%> (ø) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82c55a...cac3c7e. Read the comment docs.

@tiswanso
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-multicluster-e2e

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need ingress gateway on the remote?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the ingressgateway_test.go needs it.

@tiswanso tiswanso force-pushed the multiclus_test_fixeps2 branch from 9f346e0 to 27836d9 Compare June 28, 2018 14:32
@tiswanso
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-multicluster-e2e

2 similar comments
@tiswanso
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-multicluster-e2e

@tiswanso
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-multicluster-e2e

tiswanso and others added 14 commits July 2, 2018 11:21
Runs multicluster e2e test.  Will use mason to get GKE resources in
the same GCP project.  The resource_type will need to be updated
after the test-infra commit of the boskos config change to create the new
resource_type for multiple GKE clusters.

Script can be run with pre-allocated clusters by having a pre-setup
kubeconfig for multiple clusters.  It will choose the pilot cluster to
be the first cluster in the get-contexts or the PILOT_CLUSTER env var.

example:
PILOT_CLUSTER=gke_istio-ci-testing_us-east1-c_cluster-1 \
  KUBE_USER=tiswanso@cisco.com ROOT=$(pwd) USE_MASON_RESOURCE=False \
  prow/istio-pilot-multicluster-e2e.sh
-Add functions for multi-cluster setup to cluster_lib
gcloud IAM roles seem to have instance-template.* as a higher privilidge than instance.list|get.
- this aligns with current docs & preferred remote cluster config
  reference.
tiswanso added 2 commits July 2, 2018 11:31
…mplate

- Add istio-ingressgateway service and endpoints option to istio-remote charts
- Make the multicluster tests always setup istio-remote via helm template with
  passed args.
- Fix crash in getEndpointIPForService method
@tiswanso tiswanso force-pushed the multiclus_test_fixeps2 branch from beefd57 to 0ee2cac Compare July 3, 2018 02:23
@tiswanso
Copy link
Copy Markdown
Contributor Author

tiswanso commented Jul 3, 2018

/test istio-pilot-multicluster-e2e

@tiswanso tiswanso force-pushed the multiclus_test_fixeps2 branch from 0ee2cac to 0a57378 Compare July 3, 2018 12:37
@tiswanso
Copy link
Copy Markdown
Contributor Author

tiswanso commented Jul 3, 2018

/test istio-pilot-multicluster-e2e

…figmap

- istio-remote changes remove selectorless service/endpoint setup so DNS
  for istio control plane services won't resolve on remote.  Sidecar
  injection configmap setup on remote uses the IP addresses of services
  directly.
  - change istioctl in e2e framework to allow use of sidecar inject
    configmap on remote rather than default settings.
- enable/disable sidecar injection in remote based on test flag
- misc. fix zipkin address in istio-remote configmap
@tiswanso tiswanso force-pushed the multiclus_test_fixeps2 branch from 0a57378 to cac3c7e Compare July 3, 2018 18:07
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tiswanso
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: ostromart, yutongz

Assign the PR to them by writing /assign @ostromart @yutongz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiswanso
Copy link
Copy Markdown
Contributor Author

tiswanso commented Jul 3, 2018

/test istio-pilot-multicluster-e2e

@istio-testing
Copy link
Copy Markdown
Collaborator

@tiswanso: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-multicluster-e2e.sh cac3c7e link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stale
Copy link
Copy Markdown

stale bot commented Jul 17, 2018

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Jul 17, 2018
@rshriram rshriram closed this Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants