Skip to content

[WIP] testing Multicluster#6549

Closed
sebastienvas wants to merge 10 commits intoistio:masterfrom
sebastienvas:multicluster
Closed

[WIP] testing Multicluster#6549
sebastienvas wants to merge 10 commits intoistio:masterfrom
sebastienvas:multicluster

Conversation

@sebastienvas
Copy link
Copy Markdown
Contributor

No description provided.

tiswanso added 9 commits June 22, 2018 09:59
Runs multicluster e2e test.  Will use mason to get GKE resources in
the same GCP project.  The resource_type will need to be updated
after the test-infra commit of the boskos config change to create the new
resource_type for multiple GKE clusters.

Script can be run with pre-allocated clusters by having a pre-setup
kubeconfig for multiple clusters.  It will choose the pilot cluster to
be the first cluster in the get-contexts or the PILOT_CLUSTER env var.

example:
PILOT_CLUSTER=gke_istio-ci-testing_us-east1-c_cluster-1 \
  KUBE_USER=tiswanso@cisco.com ROOT=$(pwd) USE_MASON_RESOURCE=False \
  prow/istio-pilot-multicluster-e2e.sh
-Add functions for multi-cluster setup to cluster_lib
gcloud IAM roles seem to have instance-template.* as a higher privilidge than instance.list|get.
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 22, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebastienvas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot
Copy link
Copy Markdown
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jun 22, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 22, 2018

Codecov Report

Merging #6549 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #6549    +/-   ##
=======================================
- Coverage      68%     68%   -<1%     
=======================================
  Files         357     357            
  Lines       31304   31353    +49     
=======================================
- Hits        21204   21199     -5     
- Misses       9254    9310    +56     
+ Partials      846     844     -2
Impacted Files Coverage Δ
mixer/adapter/signalfx/registry.go 86% <0%> (-5%) ⬇️
mixer/adapter/servicecontrol/distValueBuilder.go 92% <0%> (-3%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 65% <0%> (-3%) ⬇️
mixer/adapter/signalfx/metrics.go 41% <0%> (-2%) ⬇️
galley/pkg/kube/listener.go 93% <0%> (-2%) ⬇️
mixer/adapter/fluentd/fluentd.go 74% <0%> (-1%) ⬇️
mixer/adapter/stackdriver/trace/trace.go 88% <0%> (-1%) ⬇️
pkg/util/webhookpatch.go 77% <0%> (ø) ⬇️
pilot/pkg/model/conversion.go 89% <0%> (ø) ⬇️
mixer/adapter/memquota/dedup.go 100% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c56fcb...e23f332. Read the comment docs.

@sebastienvas
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-multicluster-e2e

@sebastienvas
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-multicluster-e2e

@istio-testing
Copy link
Copy Markdown
Collaborator

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-dashboard.sh e23f332 link /test e2e-dashboard
prow/istio-pilot-multicluster-e2e.sh e23f332 link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas
Copy link
Copy Markdown
Contributor Author

Patch was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants