Skip to content

Added clusterRegistriesNamespace to istio chart.#6459

Closed
gyliu513 wants to merge 1 commit intoistio:masterfrom
gyliu513:cluster-reg-ns
Closed

Added clusterRegistriesNamespace to istio chart.#6459
gyliu513 wants to merge 1 commit intoistio:masterfrom
gyliu513:cluster-reg-ns

Conversation

@gyliu513
Copy link
Copy Markdown
Member

@gyliu513 gyliu513 commented Jun 21, 2018 •
edited
Loading

@istio-testing istio-testing requested review from sdake and tiswanso June 21, 2018 05:59
@gyliu513 gyliu513 mentioned this pull request Jun 21, 2018
Merged
@gyliu513 gyliu513 requested a review from andraxylia June 21, 2018 05:59
tiswanso
tiswanso reviewed Jun 21, 2018
View reviewed changes
install/kubernetes/helm/istio/values-istio-auth-multicluster.yaml
refreshInterval: 1s

# Namespace for ConfigMap which stores clusters configs
clusterRegistriesNamespace: istio-system
Copy link
Copy Markdown
Contributor

@tiswanso tiswanso Jun 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd want the default to be the same namespace as the other istio control-plane stuff--.Release.Namespace

Ditto for the "istio/values-istio-multicluster.yaml" and "helm/istio/values.yaml"

Copy link
Copy Markdown
Member Author

@gyliu513 gyliu513 Jun 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiswanso yes, I saw you have a PR #6446 , and once this merged, I think we do not need this PR?

Copy link
Copy Markdown
Contributor

@tiswanso tiswanso Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyliu513 -- We still need this PR to be able to control this option from helm. With #6446 it just gets taken off the list of multicluster test & doc workflow blockers.

sdake
sdake approved these changes Jun 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@sdake sdake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, sdake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gyliu513
Copy link
Copy Markdown
Member Author

gyliu513 commented Jun 28, 2018

/retest

@sdake
Copy link
Copy Markdown
Member

sdake commented Jul 7, 2018

/hold

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Jul 7, 2018
@sdake sdake removed the do-not-merge/hold Block automatic merging of a PR. label Jul 7, 2018
@stale
Copy link
Copy Markdown

stale bot commented Jul 21, 2018

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Jul 21, 2018
@rshriram rshriram closed this Jul 22, 2018
@gyliu513 gyliu513 deleted the cluster-reg-ns branch July 22, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andraxylia andraxylia Awaiting requested review from andraxylia

2 more reviewers

@tiswanso tiswanso tiswanso left review comments

@sdake sdake sdake approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sdake sdake

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gyliu513 @istio-testing @sdake @tiswanso @googlebot @rshriram