[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: objectiser
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia

Assign the PR to them by writing /assign @andraxylia in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Hi @objectiser. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Codecov Report

Merging #5814 into release-0.8 will increase coverage by 1%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           release-0.8   #5814   +/-   ##
===========================================
+ Coverage           73%     73%   +1%     
===========================================
  Files              322     322           
  Lines            27816   27721   -95     
===========================================
- Hits             20192   20161   -31     
+ Misses            6826    6755   -71     
- Partials           798     805    +7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e633b3...2a0d7b2. Read the comment docs.

Just so that you are aware, in case this PR is not merged for 0.8.0, the values-istio-demo.yaml and values-istio-demo-auth.yaml files had tracing.enabled = true - so they would need to be reverted back to zipkin.enabled = true.

@objectiser: PR needs rebase.

No longer required.