Build: Allow downstream to tweak symbols#5796
Conversation
|
/ok-to-test |
|
/retest |
1 similar comment
|
/retest |
|
krisha/seb can you take a look ? lgtm if it works but i don't know how it may impact the current official releases |
|
/lgtm |
|
/hold cancel |
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@jwendell can you resolve conflict and let's get this in |
Currently we allow users who build istio to override some version values, by providing their own "buildinfo" file with values for the version variables. Those are linked properly by the gobuild.sh script, that makes use of the -X ldflags option for the go linker. This PR makes this ability more general allowing users to override any symbol they want, by providing their own "buildinfo" file with one symbol (full path) per line, like for example: istio.io/istio/pkg/version.buildVersion=0.8 istio.io/istio/pkg/version.buildStatus=Clean This is especially useful for downstream distributors that need to tweak (at build time) a hardcoded variable other than those who control the version output.
Codecov Report
@@ Coverage Diff @@
## master #5796 +/- ##
========================================
+ Coverage 68% 73% +6%
========================================
Files 357 322 -35
Lines 31094 27846 -3248
========================================
- Hits 21018 20287 -731
+ Misses 9246 6758 -2488
+ Partials 830 801 -29
Continue to review full report at Codecov.
|
|
@ldemailly done, thanks. |
|
@jwendell: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwendell, ldemailly, sebastienvas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently we allow users who build istio to override some
version values, by providing their own "buildinfo" file with
values for the version variables. Those are linked properly
by the gobuild.sh script, that makes use of the -X ldflags
option for the go linker.
This PR makes this ability more general allowing users to
override any symbol they want, by providing their own "buildinfo"
file with one symbol (full path) per line, like for example:
istio.io/istio/pkg/version.buildVersion=0.8
istio.io/istio/pkg/version.buildStatus=Clean
This is especially useful for downstream distributors that
need to tweak (at build time) a hardcoded variable other
than those who control the version output.