[release-1.27] Nested join refactor#57098
Merged
istio-testing merged 1 commit intoistio:release-1.27from Jul 23, 2025
Merged
Conversation
Member
|
UT is still falky? |
Contributor
|
Looks like we're missing the lock around the sets? |
Contributor
Author
https://github.com/istio/istio/pull/57101/files has the lock around the sets. Both these PRs help with flakes. |
Contributor
Author
|
/retest |
* Initialize the merge cache when a new handler is added Handlers can be added after events have already been processed, so we need to copy the current state of the merge case (using the "" handlerID used by List and GetBy) for each new handler Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Refactor networks Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Remove commented out code and verbose logs Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Fix lint Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Use krt.Fetch when matching service scope This ensure that namespaces are a registered dependency to services. Otherwise, our state might become corrupted if the service is created BEFORE the namespace. --------- Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
301472e to
fa30e2c
Compare
Contributor
Author
|
@keithmattix bump |
keithmattix
approved these changes
Jul 22, 2025
zirain
approved these changes
Jul 23, 2025
Member
|
@Stevenjin8 ptal, still flaky. |
Contributor
Author
|
/retest |
Contributor
Author
|
@zirain @keithmattix is looking into it, but these PRs should help |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick for #57058