Skip to content

Improve the script to generate the jwt#5263

Closed
wattli wants to merge 0 commit intoistio:release-0.8from
wattli:master
Closed

Improve the script to generate the jwt#5263
wattli wants to merge 0 commit intoistio:release-0.8from
wattli:master

Conversation

@wattli
Copy link
Copy Markdown
Contributor

@wattli wattli commented Apr 27, 2018

The current one has error:

$ sa-jwt.py
Could not find the database of available applications, run update-command-not-found as root to fix this
sa-jwt.py: command not found

@wattli wattli requested review from diemtvu and myidpt April 27, 2018 21:23
@wattli
Copy link
Copy Markdown
Contributor Author

wattli commented Apr 30, 2018

/test e2e-simple

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-0.8@977e942). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             release-0.8   #5263   +/-   ##
=============================================
  Coverage               ?     74%           
=============================================
  Files                  ?     323           
  Lines                  ?   27216           
  Branches               ?       0           
=============================================
  Hits                   ?   19934           
  Misses                 ?    6500           
  Partials               ?     782

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977e942...8b2d3c4. Read the comment docs.

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Apr 30, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes labels Apr 30, 2018
@wattli wattli closed this Apr 30, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wattli wattli mentioned this pull request Apr 30, 2018
Merged
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 30, 2018

@wattli: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh 977e942 link /test istio-pilot-e2e
prow/istio-pilot-e2e-envoyv2-v1alpha3.sh 977e942 link /test istio-pilot-e2e-envoyv2-v1alpha3
prow/e2e-bookInfoTests-v1alpha3.sh 977e942 link /test e2e-bookInfo-envoyv2-v1alpha3
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@myidpt myidpt myidpt approved these changes

@diemtvu diemtvu diemtvu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wattli @googlebot @istio-testing @myidpt @diemtvu