Skip to content

Update istio.io/api dependency in vendor.#5197

Closed
incfly wants to merge 1 commit intoistio:masterfrom
incfly:pr-api
Closed

Update istio.io/api dependency in vendor.#5197
incfly wants to merge 1 commit intoistio:masterfrom
incfly:pr-api

Conversation

@incfly
Copy link
Copy Markdown

@incfly incfly commented Apr 25, 2018 •
edited
Loading

Run dep ensure -v -update istio.io/api to generate this PR.

#5059

@incfly incfly requested review from diemtvu and ldemailly April 25, 2018 18:22
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 25, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

Assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly
Copy link
Copy Markdown
Author

incfly commented Apr 25, 2018

FYI @yangminzhu this should also include your recent rbac change.

@incfly
Copy link
Copy Markdown
Author

incfly commented Apr 25, 2018 •
edited
Loading

@diemtvu I found the istio/api#456 removes some types like EndUserAuthnSpec but they are still used in the mixer's code. This is why some tests failing above. Should we remove istio/istio reference of those fields? Or any other suggestion to proceed?

@yangminzhu
Copy link
Copy Markdown
Contributor

yangminzhu commented Apr 25, 2018

@incfly Thanks for syncing the API repo.
I think you have to either wait for the cleaning of istio/api#456 is done or sync this PR to an earlier commit in istio/api. The latter doesn't make sense for your purpose of this PR, so probably just wait for some time.

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Apr 25, 2018

You might have to wait until the mixer change that's breaking in istio/api is reverted..

@ldemailly ldemailly requested review from nmittler and rshriram and removed request for ldemailly April 25, 2018 19:02
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 25, 2018 •
edited
Loading

@incfly: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh f92f05a link /test istio-unit-tests
prow/e2e-bookInfoTests-v1alpha3.sh f92f05a link /test e2e-bookInfo-envoyv2-v1alpha3
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rshriram
rshriram suggested changes Apr 25, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5195 is taking care of updating api dependency to istio/api#master

@incfly incfly mentioned this pull request Apr 26, 2018
Merged
@rshriram
Copy link
Copy Markdown
Member

rshriram commented Apr 26, 2018

api updated to master commit.

@rshriram rshriram closed this Apr 26, 2018
@incfly incfly deleted the pr-api branch April 26, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemtvu diemtvu Awaiting requested review from diemtvu

@nmittler nmittler Awaiting requested review from nmittler

1 more reviewer

@rshriram rshriram rshriram requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@incfly @istio-testing @yangminzhu @rshriram @googlebot