Skip to content

Add/Update Mixer e2e tests to cover more attributes sent from Envoy. …#5174

Merged
istio-merge-robot merged 1 commit intoistio:release-0.8from
JimmyCYJ:release-0.8
Apr 25, 2018
Merged

Add/Update Mixer e2e tests to cover more attributes sent from Envoy. …#5174
istio-merge-robot merged 1 commit intoistio:release-0.8from
JimmyCYJ:release-0.8

Conversation

@JimmyCYJ
Copy link
Copy Markdown
Member

@JimmyCYJ JimmyCYJ commented Apr 24, 2018 •
edited
Loading

Cherry-picked #5152 into release 0.8

@JimmyCYJ
Add/Update Mixer e2e tests to cover more attributes sent from Envoy. (#…
f52616e 
…5152)

* Add/Update Mixer e2e tests to cover more attributes sent from Envoy.

* Fix indent.
@JimmyCYJ JimmyCYJ requested a review from rshriram April 24, 2018 20:05
@JimmyCYJ
Copy link
Copy Markdown
Member Author

JimmyCYJ commented Apr 24, 2018

cc @ostromart

@JimmyCYJ
Copy link
Copy Markdown
Member Author

JimmyCYJ commented Apr 24, 2018

cc @qiwzhang

@qiwzhang
Copy link
Copy Markdown
Contributor

qiwzhang commented Apr 24, 2018

/lgtm
/approve

@JimmyCYJ JimmyCYJ requested a review from ldemailly April 24, 2018 21:26
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Apr 24, 2018

/lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-0.8@156802b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             release-0.8   #5174   +/-   ##
=============================================
  Coverage               ?     73%           
=============================================
  Files                  ?     313           
  Lines                  ?   26292           
  Branches               ?       0           
=============================================
  Hits                   ?   19134           
  Misses                 ?    6388           
  Partials               ?     770

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156802b...f52616e. Read the comment docs.

hklai
hklai approved these changes Apr 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, ldemailly, qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Apr 25, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 25, 2018 •
edited
Loading

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-bookInfoTests-v1alpha3.sh f52616e link /test e2e-bookInfo-envoyv2-v1alpha3
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Apr 25, 2018

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 05d6a94 into istio:release-0.8 Apr 25, 2018
@JimmyCYJ JimmyCYJ deleted the release-0.8 branch April 25, 2018 17:33
@shonecyx shonecyx mentioned this pull request Nov 23, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rshriram rshriram Awaiting requested review from rshriram

@ldemailly ldemailly Awaiting requested review from ldemailly

1 more reviewer

@hklai hklai hklai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ldemailly ldemailly

@qiwzhang qiwzhang

@hklai hklai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JimmyCYJ @qiwzhang @ldemailly @istio-testing @istio-merge-robot @hklai @googlebot