[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: frankbu

Assign the PR to them by writing /assign @frankbu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@frankbu: The following tests failed, say /retest to rerun them all:

The problem is that we read the host: "*" as a short name and fully qualify it (to *.default.svc.cluster.local) when we ingest the Gateway and VirtualService.

Here's a snippet of the generated config:

"virtual_hosts": [
    {
        "domains": [
            "*.default.svc.cluster.local"
        ],
        "name": "bookinfo-gateway:80",
        "routes": [
            {
                "decorator": {
                    "operation": "bookinfo-gateway"
                },
                "match": {
                    "path": "/productpage"
                },
                "route": {
                    "cluster": "outbound|http||test-server.default.svc.cluster.local",
                    "timeout": "0.000s",
                    "use_websocket": false
                }
            },

$ curl -v http://192.168.99.100:31380/login -H "Host: foo.com"
*   Trying 192.168.99.100...
* TCP_NODELAY set
* Connected to 192.168.99.100 (192.168.99.100) port 31380 (#0)
> GET /login HTTP/1.1
> Host: foo.com
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< date: Fri, 20 Apr 2018 22:32:32 GMT
< server: envoy
< content-length: 0
<
* Connection #0 to host 192.168.99.100 left intact

$ curl -v http://192.168.99.100:31380/login -H "Host: foo.default.svc.cluster.local"
*   Trying 192.168.99.100...
* TCP_NODELAY set
* Connected to 192.168.99.100 (192.168.99.100) port 31380 (#0)
> GET /login HTTP/1.1
> Host: foo.default.svc.cluster.local
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 200 OK
< date: Fri, 20 Apr 2018 22:34:34 GMT
< content-length: 27
< content-type: text/plain; charset=utf-8
< x-envoy-upstream-service-time: 1
< server: envoy
<
* Connection #0 to host 192.168.99.100 left intact
default handler echoing: ""%

I'll get a fix out shortly.

@frankbu Could you please move the old Ingress definition into samples/bookinfo/kube/bookinfo-gateway.yaml? It should be used in v1alpha1 documentation and tests, until v1alpha1 is removed.

@frankbu Thanks for the initial cut and the example gateway config. This helped us fix a big bug (thanks @ZackButcher ).
I spoke to @vadimeisenbergibm . Since he is working on sunday (israel time), I asked him to take over this work and get bookinfo working with the gateway example you have here. So, closing this PR in favor of his..