Skip to content

[test pr] check if 503s and other known bugs are fixed#5102

Merged
ldemailly merged 5 commits intomasterfrom
503s
Apr 26, 2018
Merged

[test pr] check if 503s and other known bugs are fixed#5102
ldemailly merged 5 commits intomasterfrom
503s

Conversation

@ldemailly
Copy link
Copy Markdown
Member

@ldemailly ldemailly commented Apr 20, 2018 •
edited
Loading

For issue #1038

removing the t.Skip()

Should fail in CI until we have a fix

@ldemailly
[test pr] check if 503s and other known bugs are fixed
7c8bfb0 
removing the t.Skip()

Should fail in CI until we have a fix
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 20, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yutongz

Assign the PR to them by writing /assign @yutongz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ldemailly ldemailly mentioned this pull request Apr 20, 2018
Closed
@rshriram
Copy link
Copy Markdown
Member

rshriram commented Apr 20, 2018

We already have a test for 503.. And this test will likely never pass because its using old v1 and old v1alpha1 format.

@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Apr 20, 2018

We already have a test for 503

where ?

@ldemailly
Merge branch 'master' into 503s
8b094fa
@ldemailly
Simplify the auth test
c5cbae7 
Thanks Andra for pointing out that version should fail/work the same as
using pod IP directly as the destination container never sees the
original cluster IP
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2018 •
edited
Loading

Codecov Report

Merging #5102 into master will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #5102    +/-   ##
=======================================
+ Coverage      73%     74%    +1%     
=======================================
  Files         319     319            
  Lines       26363   26570   +207     
=======================================
+ Hits        19164   19413   +249     
+ Misses       6420    6375    -45     
- Partials      779     782     +3
Impacted Files Coverage Δ
pilot/pkg/serviceregistry/kube/controller.go 63% <0%> (-4%) ⬇️
mixer/adapter/opa/opa.go 79% <0%> (-3%) ⬇️
mixer/adapter/rbac/rbac.go 10% <0%> (-1%) ⬇️
mixer/adapter/statsd/statsd.go 96% <0%> (-1%) ⬇️
mixer/adapter/fluentd/fluentd.go 75% <0%> (-1%) ⬇️
mixer/adapter/servicecontrol/reportbuilder.go 89% <0%> (ø) ⬇️
mixer/adapter/rbac/rbacStore.go 84% <0%> (ø) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 68% <0%> (ø) ⬇️
mixer/pkg/protobuf/yaml/resolver.go 100% <0%> (ø) ⬆️
mixer/adapter/solarwinds/solarwinds.go 0% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b43ca6...33be823. Read the comment docs.

@ldemailly
Merge branch 'master' into 503s
600acbc
@ldemailly
pod Ip is actually required
33be823 
Service vip doesn’t exist for non existent port and we need a non
existent port to get the bad routing behavior
@ldemailly ldemailly merged commit 33be823 into master Apr 26, 2018
@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Apr 26, 2018

this got accidentally merged, I undid the accident and will redo the PR now

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 26, 2018

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh 33be823 link /test istio-unit-tests
prow/e2e-simpleTests.sh 33be823 link /test e2e-simple
prow/e2e-bookInfoTests-v1alpha3.sh 33be823 link /test e2e-bookInfo-envoyv2-v1alpha3
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly ldemailly mentioned this pull request Apr 26, 2018
Closed
@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Apr 26, 2018

@andraxylia can you please retroactively approve the comment and yaml changes that accidentally made it early to master

@andraxylia
Copy link
Copy Markdown
Contributor

andraxylia commented Apr 26, 2018

/lgtm

ldemailly referenced this pull request Apr 26, 2018
@ldemailly
Undoing accidental merge to master
3fe027a
@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Apr 27, 2018

the revert from service back to ip missed a couple of character changes: #5241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/networking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ldemailly @istio-testing @rshriram @andraxylia @googlebot