Skip to content

Add/Update Mixer e2e tests to cover more attributes sent from Envoy.#5084

Closed
JimmyCYJ wants to merge 36 commits intoistio:masterfrom
JimmyCYJ:total-bytes-tests-2
Closed

Add/Update Mixer e2e tests to cover more attributes sent from Envoy.#5084
JimmyCYJ wants to merge 36 commits intoistio:masterfrom
JimmyCYJ:total-bytes-tests-2

Conversation

@JimmyCYJ
Copy link
Copy Markdown
Member

@JimmyCYJ JimmyCYJ commented Apr 19, 2018

Add/Update Mixer e2e tests to cover more attributes sent from Envoy. The attributes are introduced by istio/proxy@d20cd6d and istio/proxy@e562a1b.

@JimmyCYJ JimmyCYJ requested a review from qiwzhang April 19, 2018 21:15
@ostromart ostromart mentioned this pull request Apr 19, 2018
Merged
@qiwzhang
Copy link
Copy Markdown
Contributor

qiwzhang commented Apr 19, 2018

/lgtm
/approve

@istio-testing istio-testing added lgtm and removed lgtm labels Apr 19, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2018 •
edited
Loading

Codecov Report

Merging #5084 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #5084    +/-   ##
=======================================
- Coverage      74%     74%   -<1%     
=======================================
  Files         313     313            
  Lines       25618   25658    +40     
=======================================
- Hits        18843   18831    -12     
- Misses       6044    6097    +53     
+ Partials      731     730     -1
Impacted Files Coverage Δ
pilot/pkg/networking/core/v1alpha3/listener.go 0% <ø> (ø) ⬆️
pilot/cmd/pilot-discovery/main.go 69% <0%> (-7%) ⬇️
pilot/pkg/model/jwks_resolver.go 56% <0%> (-6%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 68% <0%> (ø) ⬇️
mixer/adapter/servicecontrol/quotaprocessor.go 82% <0%> (ø) ⬇️
mixer/pkg/protobuf/yaml/castUtil.go 100% <0%> (ø) ⬆️
mixer/adapter/stdio/zap.go 100% <0%> (ø) ⬆️
mixer/adapter/stdio/stdio.go 100% <0%> (ø) ⬆️
mixer/adapter/solarwinds/solarwinds.go 0% <0%> (ø) ⬆️
mixer/adapter/memquota/dedup.go 100% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280fcd0...f9e7caa. Read the comment docs.

@qiwzhang
Copy link
Copy Markdown
Contributor

qiwzhang commented Apr 24, 2018

/lgtm
/approve

@qiwzhang
Copy link
Copy Markdown
Contributor

qiwzhang commented Apr 24, 2018

/approve cancel

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 24, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid

Assign the PR to them by writing /assign @geeknoid in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 24, 2018

New changes are detected. LGTM label has been removed.

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Apr 24, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes labels Apr 24, 2018
@JimmyCYJ JimmyCYJ closed this Apr 24, 2018
@JimmyCYJ
Copy link
Copy Markdown
Member Author

JimmyCYJ commented Apr 24, 2018

Created another new PR #5152, which is the same as this one. To avoid the CLA issue.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 24, 2018

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-bookInfoTests-v1alpha3.sh f9e7caa link /test e2e-bookInfo-envoyv2-v1alpha3
prow/istio-pilot-e2e.sh f9e7caa link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiwzhang qiwzhang Awaiting requested review from qiwzhang

Assignees

@qiwzhang qiwzhang

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JimmyCYJ @qiwzhang @istio-testing @googlebot @kimikowang @gargnupur @hklai