Move EndpointIndex logic to common area, use in ConfigGenTest#46374
Merged
istio-testing merged 1 commit intoistio:masterfrom Aug 8, 2023
Merged
Conversation
This makes no change in prod code, and almost no change in test code. It is a dependency for istio#46329, though. Once that lands, we need a proper XDSUpdater keeping the EndpointIndex in sync for all cases; today the tets under v1alpha3/ do not use a DiscoveryServer (can cannot - looping deps), but they need an EndpointIndex. This prepares them to use one.
eabdad3 to
7a995ed
Compare
hzxuzhonghu
approved these changes
Aug 8, 2023
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes no change in prod code, and almost no change in test code. It
is a dependency for #46329, though.
Once that lands, we need a proper XDSUpdater keeping the EndpointIndex
in sync for all cases; today the tets under v1alpha3/ do not use a
DiscoveryServer (can cannot - looping deps), but they need an
EndpointIndex. This prepares them to use one.