Always Use .Release.Namespace in the ClusterRoleBinding Name by mandarjog · Pull Request #4546 · istio/istio

mandarjog · 2018-03-26T23:57:42Z

Ensures that all clusterRoleBinding has name of namespace encoded in it.

This is needed for one-namespace testing.

mandarjog · 2018-03-26T23:59:10Z

fixes #4547

mandarjog · 2018-03-27T00:34:30Z

/test e2e-suite-rbac-auth

ldemailly · 2018-03-27T00:37:05Z

/lgtm

istio-merge-robot · 2018-03-27T00:38:09Z

/test all [submit-queue is verifying that this PR is safe to merge]

codecov · 2018-03-27T14:03:43Z

Codecov Report

Merging #4546 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4546    +/-   ##
=======================================
- Coverage      74%     74%   -<1%     
=======================================
  Files         294     294            
  Lines       24667   24719    +52     
=======================================
+ Hits        18136   18154    +18     
- Misses       5778    5807    +29     
- Partials      753     758     +5

Impacted Files	Coverage Δ
pilot/pkg/config/memory/monitor.go	`82% <0%> (-9%)`	⬇️
mixer/adapter/solarwinds/metrics_handler.go	`75% <0%> (-8%)`	⬇️
pilot/pkg/model/authentication.go	`75% <0%> (-4%)`	⬇️
mixer/adapter/opa/opa.go	`79% <0%> (-3%)`	⬇️
mixer/adapter/kubernetesenv/cache.go	`83% <0%> (-2%)`	⬇️
mixer/tools/adapterlinter/main.go	`89% <0%> (-1%)`	⬇️
pilot/pkg/model/validation.go	`88% <0%> (ø)`	⬇️
mixer/adapter/list/ipList.go	`100% <0%> (ø)`	⬆️
mixer/adapter/stdio/stdio.go	`100% <0%> (ø)`	⬆️
mixer/adapter/stdio/zap.go	`100% <0%> (ø)`	⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc71c3...0d4fc30. Read the comment docs.

cmluciano · 2018-03-27T14:42:31Z

/lgtm

istio-merge-robot · 2018-03-27T14:43:08Z

/test all [submit-queue is verifying that this PR is safe to merge]

mandarjog · 2018-03-27T15:03:53Z

/test e2e-suite-rbac-auth

cmluciano · 2018-03-27T15:12:49Z

Makefile

-istio-auth.yaml: $(HELM)
+# creates istio.yaml istio-auth.yaml istio-one-namespace.yaml istio-one-namespace-auth.yaml
+# Ensure that values-$filename is present in install/kubernetes/helm/istio
+isti%.yaml: $(HELM)


istio%.yaml does not match istio.yaml. % is one or more ?

sorry missed the matching here

cmluciano · 2018-03-27T15:40:52Z

/lgtm

istio-testing · 2018-03-27T15:40:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, ldemailly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ldemailly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

istio-merge-robot · 2018-03-27T15:41:27Z

/test all [submit-queue is verifying that this PR is safe to merge]

istio-testing · 2018-03-27T15:53:45Z

@mandarjog: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
prow/e2e-suite-rbac-auth.sh	`031b223`	link	`/test e2e-suite-rbac-auth`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandarjog · 2018-03-27T16:09:25Z

I0327 15:44:03.254] === RUN   TestDashboards/Mixer
I0327 15:44:05.228] 2018-03-27T15:44:05.228309Z	info	Running command kubectl get pods -n dashboard-test-ffab4487e02a4a4d9a6d09 -l app=echosrv -o jsonpath={.items[*].metadata.name}
I0327 15:44:05.552] 2018-03-27T15:44:05.552233Z	info	Command output: 
I0327 15:44:05.552] echosrv-deployment-77878768fb-xgqnw
I0327 15:44:05.553] 2018-03-27T15:44:05.552299Z	info	Running command kubectl exec -n dashboard-test-ffab4487e02a4a4d9a6d09 echosrv-deployment-77878768fb-xgqnw -c echosrv -- /usr/local/bin/fortio curl http://istio-telemetry.dashboard-test-ffab4487e02a4a4d9a6d09:9093/metrics
I0327 15:44:06.246] 2018-03-27T15:44:06.245995Z	info	Command output: 
I0327 15:44:06.246] 15:44:06 W http_client.go:584> Parsed non ok code 503 (HTTP/1.1 503)
I0327 15:44:06.246] 15:44:06 E commonflags.go:104> Error status 503 : HTTP/1.1 503 Service Unavailable\r\ncontent-length: 57\r\ncontent-type: text/plain\r\ndate: Tue, 27 Mar 2018 15:44:06 GMT\r\nserver: envoy\r\n\r\nupstream connect error or disconnect/reset before headers
I0327 15:44:06.247] HTTP/1.1 503 Service Unavailable
I0327 15:44:06.247] content-length: 57
I0327 15:44:06.247] content-type: text/plain
I0327 15:44:06.247] date: Tue, 27 Mar 2018 15:44:06 GMT
I0327 15:44:06.247] server: envoy
I0327 15:44:06.247] 
I0327 15:44:06.247] upstream connect error or disconnect/reset before headerscommand terminated with exit code 1
I0327 15:44:06.247] 2018-03-27T15:44:06.246066Z	info	Command error: exit status 1
I0327 15:44:06.247] === RUN   TestDashboards/Pilot
I0327 15:44:07.803] 2018-03-27T15:44:07.802783Z	info	Running command kubectl get pods -n dashboard-test-ffab4487e02a4a4d9a6d09 -l app=echosrv -o jsonpath={.items[*].metadata.name}
I0327 15:44:08.133] 2018-03-27T15:44:08.133253Z	info	Command output: 
I0327 15:44:08.133] echosrv-deployment-77878768fb-xgqnw
I0327 15:44:08.134] 2018-03-27T15:44:08.133333Z	info	Running command kubectl exec -n dashboard-test-ffab4487e02a4a4d9a6d09 echosrv-deployment-77878768fb-xgqnw -c echosrv -- /usr/local/bin/fortio curl http://istio-pilot.dashboard-test-ffab4487e02a4a4d9a6d09:9093/metrics
I0327 15:44:08.811] 2018-03-27T15:44:08.810993Z	info	Command output: 
I0327 15:44:08.812] 15:44:08 W http_client.go:584> Parsed non ok code 503 (HTTP/1.1 503)
I0327 15:44:08.812] 15:44:08 E commonflags.go:104> Error status 503 : HTTP/1.1 503 Service Unavailable\r\ncontent-length: 57\r\ncontent-type: text/plain\r\ndate: Tue, 27 Mar 2018 15:44:08 GMT\r\nserver: envoy\r\n\r\nupstream connect error or disconnect/reset before headers
I0327 15:44:08.812] HTTP/1.1 503 Service Unavailable
I0327 15:44:08.812] content-length: 57
I0327 15:44:08.812] content-type: text/plain
I0327 15:44:08.812] date: Tue, 27 Mar 2018 15:44:08 GMT
I0327 15:44:08.812] server: envoy
I0327 15:44:08.812] 
I0327 15:44:08.812] upstream connect error or disconnect/reset before headerscommand terminated with exit code 1

cmluciano · 2018-03-27T16:10:48Z

related #4420

istio-merge-robot · 2018-03-27T16:17:40Z

Automatic merge from submit-queue.

Always Use .Release.Namespace in the ClusterRoleBinding Name

805074f

mandarjog requested a review from costinm March 26, 2018 23:57

googlebot added the cla: yes label Mar 26, 2018

mandarjog requested a review from ldemailly March 27, 2018 00:35

istio-testing assigned ldemailly Mar 27, 2018

istio-testing added lgtm labels Mar 27, 2018

mandarjog added 2 commits March 26, 2018 23:37

fix direct metrics dump host and port

b59af8d

Ensure that helm gets installed when needed

031b223

istio-testing removed the lgtm label Mar 27, 2018

istio-testing assigned cmluciano Mar 27, 2018

istio-testing added the lgtm label Mar 27, 2018

Use wildcard yaml rule with value sets

0d4fc30

istio-testing removed the lgtm label Mar 27, 2018

cmluciano reviewed Mar 27, 2018

View reviewed changes

istio-testing added the lgtm label Mar 27, 2018

istio-merge-robot merged commit 692e481 into istio:master Mar 27, 2018

This was referenced Mar 27, 2018

Add better check for Mixer config health to dash test #4506

Merged

Use 'helm template' to generate istio artifacts #4001

Merged

Conversation

mandarjog commented Mar 26, 2018

Uh oh!

mandarjog commented Mar 26, 2018

Uh oh!

mandarjog commented Mar 27, 2018

Uh oh!

ldemailly commented Mar 27, 2018

Uh oh!

istio-merge-robot commented Mar 27, 2018

Uh oh!

codecov bot commented Mar 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cmluciano commented Mar 27, 2018

Uh oh!

istio-merge-robot commented Mar 27, 2018

Uh oh!

mandarjog commented Mar 27, 2018

Uh oh!

cmluciano Mar 27, 2018

Choose a reason for hiding this comment

Uh oh!

mandarjog Mar 27, 2018

Choose a reason for hiding this comment

Uh oh!

cmluciano Mar 27, 2018

Choose a reason for hiding this comment

Uh oh!

cmluciano commented Mar 27, 2018

Uh oh!

istio-testing commented Mar 27, 2018

Uh oh!

istio-merge-robot commented Mar 27, 2018

Uh oh!

istio-testing commented Mar 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mandarjog commented Mar 27, 2018

Uh oh!

cmluciano commented Mar 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

istio-merge-robot commented Mar 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Mar 27, 2018 •

edited

Loading

istio-testing commented Mar 27, 2018 •

edited

Loading

cmluciano commented Mar 27, 2018 •

edited

Loading