Set integer seconds for CORS max age#4324
Merged
rshriram merged 4 commits intoistio:masterfrom Mar 19, 2018
Merged
Conversation
Merged
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4324 +/- ##
=======================================
- Coverage 71% 70% -<1%
=======================================
Files 315 315
Lines 29042 28981 -61
=======================================
- Hits 20360 20265 -95
- Misses 7462 7489 +27
- Partials 1220 1227 +7
Continue to review full report at Codecov.
|
kyessenov
approved these changes
Mar 16, 2018
rshriram
approved these changes
Mar 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was never set correctly. It should be integer seconds, not Go duration strings (
2m5s, etc): https://www.w3.org/TR/cors/#access-control-max-age-response-header