Skip to content

[release-1.14] Check if metadata endpoint is available and trigger Gcp requests concurrently#41955

Closed
istio-testing wants to merge 3 commits intoistio:release-1.14from
istio-testing:cherry-pick-40105-to-release-1.14
Closed

[release-1.14] Check if metadata endpoint is available and trigger Gcp requests concurrently#41955
istio-testing wants to merge 3 commits intoistio:release-1.14from
istio-testing:cherry-pick-40105-to-release-1.14

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

@istio-testing istio-testing commented Nov 11, 2022

This is an automated cherry-pick of #40105

@istio-testing istio-testing requested a review from a team November 11, 2022 17:33
@istio-testing istio-testing mentioned this pull request Nov 11, 2022
Merged
2 tasks
@istio-testing istio-testing added release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2022
@rinormaloku @istio-testing
Query GCP Instance Metadata concurrently
97da2ad 
Signed-off-by: rinormaloku <rinormaloku37@gmail.com>
@rinormaloku @istio-testing
Checking if GCP Metadata endpoint is available
bfe2b7d 
Signed-off-by: rinormaloku <rinormaloku37@gmail.com>
@rinormaloku @istio-testing
Checking if GCP Metadata endpoint is available
028bfce 
Signed-off-by: rinormaloku <rinormaloku37@gmail.com>
@istio-testing istio-testing force-pushed the cherry-pick-40105-to-release-1.14 branch from 0154679 to 028bfce Compare November 11, 2022 17:34
lei-tang
lei-tang reviewed Nov 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lei-tang lei-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Istio WG has a cherry-picking policy that only major bug fixes and CVE fixes can be cherry-picked. This PR may not meet such criteria and be cherry-picked into release-1.14 branch.

@dhawton
Copy link
Copy Markdown
Member

dhawton commented Nov 11, 2022

Istio WG has a cherry-picking policy that only major bug fixes and CVE fixes can be cherry-picked. This PR may not meet such criteria and be cherry-picked into release-1.14 branch.

I cherry picked here because it was cherry picked into 1.13... so it's something that is in 1.13 and 1.16, but missing from 1.14 and 1.15?

@lei-tang
Copy link
Copy Markdown
Contributor

lei-tang commented Nov 11, 2022

Istio 1.13 has reached its EOL and no new patch release will be made.

@dhawton
Copy link
Copy Markdown
Member

dhawton commented Nov 11, 2022

Istio 1.13 has reached its EOL and no new patch release will be made.

This isn't about 1.13?

@dhawton
Copy link
Copy Markdown
Member

dhawton commented Nov 11, 2022

Note: This PR is dependent on #40700 being backported as well

lei-tang
lei-tang approved these changes Nov 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lei-tang lei-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per offline chat, this PR has been cherry-picked into 1.13: #40746.
For consistency, this PR can be cherry-picked into 1.14.

@dhawton dhawton added the do-not-merge Block automatic merging of a PR. label Nov 11, 2022
@dhawton
Copy link
Copy Markdown
Member

dhawton commented Nov 11, 2022

DNM added pending dependency PR, needs manual cherry picking

@dhawton dhawton closed this Nov 11, 2022
@dhawton
Copy link
Copy Markdown
Member

dhawton commented Nov 11, 2022

Going to cherry pick into single PR to ensure they both go in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lei-tang lei-tang lei-tang approved these changes

Assignees

No one assigned

Labels

do-not-merge Block automatic merging of a PR. release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@istio-testing @dhawton @lei-tang @rinormaloku