fix consul and eureka bookinfo sidecars#4181
fix consul and eureka bookinfo sidecars#4181rkpagadala merged 1 commit intoistio:masterfrom rkpagadala:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4181 +/- ##
=======================================
- Coverage 73% 73% -<1%
=======================================
Files 313 313
Lines 28898 28894 -4
=======================================
- Hits 21028 21016 -12
- Misses 6543 6554 +11
+ Partials 1327 1324 -3
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@rkpagadala: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Other instances to consider: install/kubernetes/templates/istio-sidecar-injector-configmap-release.yaml.tmpl: image: {PILOT_HUB}/proxy_init:{PILOT_TAG}
install/kubernetes/templates/istio-sidecar-injector-configmap-release.yaml.tmpl: image: {PILOT_HUB}/proxy:{PILOT_TAG}
install/kubernetes/templates/istio-sidecar-injector-configmap-debug.yaml.tmpl: image: {PILOT_HUB}/proxy_init:{PILOT_TAG}
install/kubernetes/templates/istio-sidecar-injector-configmap-debug.yaml.tmpl: image: {PILOT_HUB}/proxy_debug:{PILOT_TAG}
samples/bookinfo/eureka/templates/bookinfo.sidecars.yaml.tmpl: image: {PILOT_HUB}/proxy_init:{PILOT_TAG}
I'm assuming proxy and proxy_debug should be using the same hub/tag variable though I'm not sure if proxy_init should also be using that or if pilot's hub/tag is okay. There's several instances in the last file I quoted. |
No description provided.