Skip to content

Add more end-to-end Mixer report tests#4076

Merged
ozevren merged 1 commit intoistio:masterfrom
ozevren:fixit2
Mar 11, 2018
Merged

Add more end-to-end Mixer report tests#4076
ozevren merged 1 commit intoistio:masterfrom
ozevren:fixit2

Conversation

@ozevren
Copy link
Copy Markdown
Contributor

@ozevren ozevren commented Mar 8, 2018 •
edited
Loading

Add some more e2e test cases.

@ozevren ozevren requested review from a team and guptasu March 8, 2018 03:20
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2018 •
edited
Loading

Codecov Report

Merging #4076 into master will increase coverage by 3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4076     +/-   ##
========================================
+ Coverage      73%     76%     +3%     
========================================
  Files         313     305      -8     
  Lines       28647   27423   -1224     
========================================
- Hits        20846   20666    -180     
+ Misses       6492    5492   -1000     
+ Partials     1309    1265     -44
Impacted Files Coverage Δ
.../adapter/solarwinds/internal/appoptics/batching.go 70% <0%> (-18%) ⬇️
mixer/adapter/stackdriver/stackdriver.go 55% <0%> (-15%) ⬇️
pilot/pkg/config/monitor/monitor.go 69% <0%> (-5%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 64% <0%> (-4%) ⬇️
pilot/pkg/serviceregistry/kube/queue.go 86% <0%> (-3%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 68% <0%> (-1%) ⬇️
mixer/adapter/rbac/rbacStore.go 83% <0%> (-1%) ⬇️
mixer/adapter/stackdriver/metric/bufferedClient.go 93% <0%> (ø) ⬇️
pilot/pkg/proxy/envoy/v2/mesh_discovery.go 55% <0%> (ø) ⬇️
mixer/adapter/memquota/rollingWindow.go 100% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7752f...e9425bc. Read the comment docs.

@ozevren ozevren mentioned this pull request Mar 8, 2018
Merged
@ozevren ozevren changed the title WIP: Add more end-to-end Mixer tests Add more end-to-end Mixer report tests Mar 8, 2018
guptasu
guptasu reviewed Mar 8, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@guptasu guptasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it... thanks for covering all the fancy cases.

I am guessing, you are going to add check tests too. Do you think we should move the attribute config reportGlobalCfg at a higher level so other tests can use it directly, in fact that config is always available when using testdata.Run

@guptasu
Copy link
Copy Markdown
Contributor

guptasu commented Mar 8, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Mar 8, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@ozevren
Copy link
Copy Markdown
Contributor Author

ozevren commented Mar 8, 2018

Sounds like a good idea. I can do it in a later check-in.

@ozevren ozevren requested a review from a team March 9, 2018 16:58
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Mar 9, 2018

/lgtm cancel //PR changed after LGTM, removing LGTM. @guptasu @ozevren

@guptasu
Copy link
Copy Markdown
Contributor

guptasu commented Mar 9, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Mar 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guptasu

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Mar 10, 2018

/lgtm cancel //PR changed after LGTM, removing LGTM. @guptasu @ozevren

@ozevren
Copy link
Copy Markdown
Contributor Author

ozevren commented Mar 10, 2018

/retest

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 10, 2018 •
edited
Loading

@ozevren: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh e9425bc link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren ozevren merged commit 7db319c into istio:master Mar 11, 2018
@ozevren ozevren deleted the fixit2 branch March 14, 2018 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@guptasu guptasu guptasu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@guptasu guptasu

Labels

area/extensions and telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ozevren @guptasu @istio-merge-robot @istio-testing @googlebot