Skip to content

wip: experimental with single listener for headless#40409

Closed
howardjohn wants to merge 2 commits intoistio:masterfrom
howardjohn:exp/headless-shared
Closed

wip: experimental with single listener for headless#40409
howardjohn wants to merge 2 commits intoistio:masterfrom
howardjohn:exp/headless-shared

Conversation

@howardjohn
Copy link
Copy Markdown
Member

@howardjohn howardjohn commented Aug 11, 2022 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Aug 11, 2022
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Aug 11, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Aug 11, 2022
@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented Aug 11, 2022

/test all

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 11, 2022
@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented Aug 11, 2022

/test all

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Aug 11, 2022 •
edited
Loading

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests-arm64_istio 54f3fc9 link true /test unit-tests-arm64_istio
unit-tests_istio 54f3fc9 link true /test unit-tests_istio
lint_istio 54f3fc9 link true /test lint_istio
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented Aug 12, 2022

cc @hzxuzhonghu

@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented Aug 12, 2022

On issue is we now drain all of them even if only one changes...

@howardjohn howardjohn mentioned this pull request Aug 17, 2022
Open
@zhlsunshine
Copy link
Copy Markdown
Contributor

zhlsunshine commented Aug 18, 2022

Hi @howardjohn & @hzxuzhonghu, I think this is a great example of using multi-addresses per listener for headless service. ^_^

This was referenced Aug 22, 2022
Merged
Merged
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Sep 17, 2022
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Oct 1, 2022

@howardjohn: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 1, 2022
@istio-policy-bot
Copy link
Copy Markdown

istio-policy-bot commented Oct 2, 2022

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-08-18. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@howardjohn @istio-testing @zhlsunshine @istio-policy-bot