1.15: cherrypick arm64 support#40334
Merged
istio-testing merged 5 commits intoistio:release-1.15from Aug 8, 2022
Merged
Conversation
* Cleanup some more legacy fields * fix packaging.mk (cherry picked from commit 2da7b19)
* Allow no cpuinfo * allow fail * Bump kind image * debug * workaround env var * fix docker build * log * arch in build * set arch again * fix arch type * more logs * more env * Make single image architecture aware * VM per-arch * Opt out when requiring emulation * Fix jwt server * fmt * Revert env var hacks * cleanup * minor fixes * new release-builder * multi-arch * lint (cherry picked from commit ef5c246)
* Add qemulation to release builder VMs currently require emulation to cross compile. We previously just skipped them, but then you cannot simply run `go test ./tests/integration/...` with `gcr.io/istio-testing` since we don't have the VM images. Instead, try emulation. * Use our image (cherry picked from commit 9c770dc)
(cherry picked from commit 0d59fec)
dhawton
approved these changes
Aug 8, 2022
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Fixes #40333