Skip to content

[release-1.15] fix empty endpoints weight for AUTO_PASSTHROUGH gateway#40313

Merged
istio-testing merged 2 commits intoistio:release-1.15from
bincherry:fix_empty_endpoints_weight_release-1.15
Aug 8, 2022
Merged

[release-1.15] fix empty endpoints weight for AUTO_PASSTHROUGH gateway#40313
istio-testing merged 2 commits intoistio:release-1.15from
bincherry:fix_empty_endpoints_weight_release-1.15

Conversation

@bincherry
Copy link
Copy Markdown
Member

@bincherry bincherry commented Aug 6, 2022 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

Manual cherrypick of #40243

This cannot be done by a bot because there are different struct names on the two branches, according to #40226 , which changes LocLbEndpointsAndOptions to LocalityEndpoints on master branch.

bincherry and others added 2 commits August 6, 2022 08:35
@bincherry
fix empty endpoints weight for AUTO_PASSTHROUGH gateway (istio#40243)
a6b35a6 
* fix empty endpoints weight for AUTO_PASSTHROUGH gateway

* add a test
@bincherry
fix the test
65ff1da
@bincherry bincherry requested a review from a team August 6, 2022 01:10
@istio-policy-bot istio-policy-bot added area/networking release-notes-none Indicates a PR that does not require release notes. labels Aug 6, 2022
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 6, 2022
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Aug 6, 2022

Hi @bincherry. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zirain
Copy link
Copy Markdown
Member

zirain commented Aug 6, 2022

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 6, 2022
@bincherry
Copy link
Copy Markdown
Member Author

bincherry commented Aug 6, 2022

It seems that something wrong with the arm64 testing. Need some help please.

@zirain
Copy link
Copy Markdown
Member

zirain commented Aug 6, 2022

cc @howardjohn arm64 is supported on v1.15?

@ericvn
Copy link
Copy Markdown
Contributor

ericvn commented Aug 8, 2022

/retest

@istio-testing istio-testing merged commit d952629 into istio:release-1.15 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhawton dhawton dhawton approved these changes

Assignees

No one assigned

Labels

area/networking ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bincherry @istio-testing @zirain @ericvn @dhawton @istio-policy-bot