Skip to content

Deb URL to not Depend on istioctl_url#3993

Merged
rkpagadala merged 3 commits intoistio:masterfrom
chxchx:debURL
Mar 6, 2018
Merged

Deb URL to not Depend on istioctl_url#3993
rkpagadala merged 3 commits intoistio:masterfrom
chxchx:debURL

Conversation

@chxchx
Copy link
Copy Markdown
Contributor

@chxchx chxchx commented Mar 6, 2018 •
edited
Loading

fixes #3995

@chxchx chxchx requested a review from a team March 6, 2018 00:43
@chxchx
Copy link
Copy Markdown
Contributor Author

chxchx commented Mar 6, 2018

/assign @rkpagadala @sebastienvas

@chxchx chxchx mentioned this pull request Mar 6, 2018
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2018 •
edited
Loading

Codecov Report

Merging #3993 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #3993    +/-   ##
=======================================
- Coverage      77%     76%   -<1%     
=======================================
  Files         297     297            
  Lines       26703   27137   +434     
=======================================
+ Hits        20301   20515   +214     
- Misses       5135    5294   +159     
- Partials     1267    1328    +61
Impacted Files Coverage Δ
mixer/adapter/opa/opa.go 79% <0%> (-3%) ⬇️
pilot/pkg/model/conversion.go 86% <0%> (-2%) ⬇️
mixer/adapter/servicecontrol/testhelper.go 72% <0%> (-2%) ⬇️
pilot/pkg/model/egress_rules.go 95% <0%> (-2%) ⬇️
mixer/adapter/stackdriver/metric/distribution.go 85% <0%> (-1%) ⬇️
mixer/template/sample/template.gen.go 55% <0%> (ø) ⬇️
mixer/adapter/fluentd/fluentd.go 77% <0%> (ø) ⬇️
mixer/adapter/circonus/circonus.go 71% <0%> (ø) ⬇️
pilot/pkg/proxy/envoy/v1/mixer.go 89% <0%> (ø) ⬇️
mixer/adapter/stdio/stdio.go 100% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa9247...36e84a4. Read the comment docs.

@rkpagadala
Copy link
Copy Markdown
Contributor

rkpagadala commented Mar 6, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Mar 6, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkpagadala
We suggest the following additional approver: sebastienvas

Assign the PR to them by writing /assign @sebastienvas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

ldemailly
ldemailly approved these changes Mar 6, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just github approving because krishna lgtm'ed
so you can merge if you feel it's safe/tested

@rkpagadala rkpagadala merged commit c5d9338 into istio:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rkpagadala rkpagadala

@sebastienvas sebastienvas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable VM tests for release pipeline

7 participants

@chxchx @rkpagadala @istio-merge-robot @ldemailly @googlebot @sebastienvas @istio-testing