Skip to content

Switch CI badge to match style of other badges. [skip ci].#3932

Merged
ldemailly merged 1 commit intoistio:masterfrom
FelicianoTech:swap-ci-badge-style
Mar 4, 2018
Merged

Switch CI badge to match style of other badges. [skip ci].#3932
ldemailly merged 1 commit intoistio:masterfrom
FelicianoTech:swap-ci-badge-style

Conversation

@FelicianoTech
Copy link
Copy Markdown
Contributor

@FelicianoTech FelicianoTech commented Mar 3, 2018

Switches the badge style to make the same style (shield) as the other readme badges.

[skip ci] is used since this is a readme fix and doesn't affect any code whatsoever.

@FelicianoTech FelicianoTech requested a review from a team March 3, 2018 21:48
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 3, 2018

Hi @FelicianoTech. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2018 •
edited
Loading

Codecov Report

Merging #3932 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #3932    +/-   ##
=======================================
- Coverage      76%     76%   -<1%     
=======================================
  Files         297     297            
  Lines       27290   27194    -96     
=======================================
- Hits        20611   20517    -94     
  Misses       5350    5350            
+ Partials     1329    1327     -2
Impacted Files Coverage Δ
mixer/adapter/list/regexList.go 69% <0%> (-9%) ⬇️
mixer/adapter/fluentd/fluentd.go 76% <0%> (-4%) ⬇️
mixer/adapter/stdio/zap.go 97% <0%> (-1%) ⬇️
mixer/adapter/kubernetesenv/cache.go 83% <0%> (-1%) ⬇️
mixer/adapter/rbac/rbacStore.go 83% <0%> (-1%) ⬇️
mixer/adapter/list/list.go 95% <0%> (ø) ⬇️
mixer/adapter/stdio/stdio.go 100% <0%> (ø) ⬆️
mixer/adapter/servicecontrol/client.go 0% <0%> (ø) ⬆️
mixer/adapter/memquota/rollingWindow.go 100% <0%> (ø) ⬆️
mixer/adapter/kubernetesenv/kubernetesenv.go 69% <0%> (+1%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f434fc2...b77c0db. Read the comment docs.

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Mar 4, 2018

Thanks ! I didn’t know about this, want to submit the same for fortio too?

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Mar 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly merged commit 4081af6 into istio:master Mar 4, 2018
@FelicianoTech
Copy link
Copy Markdown
Contributor Author

FelicianoTech commented Mar 4, 2018

@ldemailly np. Opened: fortio/fortio#174

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 4, 2018

@FelicianoTech: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh b77c0db link /test istio-unit-tests
prow/istio-presubmit.sh b77c0db link /test istio-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@FelicianoTech FelicianoTech deleted the swap-ci-badge-style branch March 4, 2018 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ldemailly ldemailly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FelicianoTech @istio-testing @ldemailly @istio-merge-robot @googlebot