Change the Infof to Debugf in KindMap() to fix #3835.#3925
Change the Infof to Debugf in KindMap() to fix #3835.#3925yangminzhu merged 1 commit intoistio:masterfrom
Conversation
|
I'm trying to pick some starter issues to help to ramp up on Istio, please let me know if you think we should not change the default logging level, I'll try to fix the issue in a different way. |
|
/lgtm, but i will defer the approval to Mandar/Martin |
Codecov Report
@@ Coverage Diff @@
## master #3925 +/- ##
======================================
+ Coverage 76% 76% +1%
======================================
Files 297 297
Lines 27210 27197 -13
======================================
+ Hits 20537 20578 +41
+ Misses 5348 5291 -57
- Partials 1325 1328 +3
Continue to review full report at Codecov.
|
pkg/log/options.go
Outdated
There was a problem hiding this comment.
We can't change this for the product, the intent is for Info to be the default and changing this now will remove a considerable amount of log info we depend on.
|
This change is not appropriate, the default log level must stay at Info for the product. What specific issue is this trying to fix? |
|
This is to fix #3835. |
|
@yangminzhu the proper fix is probably to move the spew to Debug rather than change the default to Warning. That or decide because it's a one time spew it is actually appropriate and useful to see at startup/once What we want to make sure is we don't log anything at Info for every request. |
|
The solution to #3835 is definitely just to change the simple log statement in mixs and not to change the system's default log level globally. Thanks. |
|
@geeknoid Thanks for the suggestion! These logging information are generated from the calling to runtime.KindMap() in mixer/cmd/mixs/cmd/validator.go:39. And it's KindMap() that calls log.Infof() which in turn produces these information. (ea7303f#diff-9476892d25087e7c68a6c9343c536b64R72) @mandarjog Could you let me know if it's ok to change the log.Infof() in KindMap() to Debug level to fix the issue? |
|
Yes, that's totally appropriate.
…On Fri, Mar 2, 2018 at 7:19 PM, Yangmin ***@***.***> wrote:
@geeknoid <https://github.com/geeknoid> Thanks for the suggestion!
These logging information are generated from the calling to
runtime.KindMap() in mixer/cmd/mixs/cmd/validator.go:39. And it's
KindMap() that calls log.Infof() which in turn produces these information. (
ea7303f#diff-9476892d25087e7c68a6c9343c536b64R72
<ea7303f#diff-9476892d25087e7c68a6c9343c536b64R72>
)
@mandarjog <https://github.com/mandarjog> Could you let me know if it's
ok to change the log.Infof() in KindMap() to Debug level to fix the issue?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3925 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AVucHes1A0etrskGtMBaJD1dh1iVd2FCks5tagukgaJpZM4SatUq>
.
|
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geeknoid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @geeknoid @yangminzhu |
|
@yangminzhu: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
In #3759, it changed pkg/log/log.go to use default logging options which sets to InfoLevel by default.