Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #3924 +/- ##
======================================
+ Coverage 76% 76% +1%
======================================
Files 297 297
Lines 27210 27293 +83
======================================
+ Hits 20537 20621 +84
+ Misses 5348 5341 -7
- Partials 1325 1331 +6
Continue to review full report at Codecov.
|
|
/retest |
|
@diemtvu: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| Name: name, | ||
| Group: "config.istio.io", | ||
| Version: "v1alpha2", | ||
| Group: c.schema.Group + model.IstioAPIGroupDomain, |
There was a problem hiding this comment.
This should be ResourceGroup(c.schema).
There was a problem hiding this comment.
It would cause circular dependency. I guess we will need to refactor the code a bit later.
There was a problem hiding this comment.
ok. ResourceGroup has to stay in crd. Let's keep this for now.
The test was using hardcoded value for group and version. Change it to the one defined by ProtoSchema for the modernize IstioConfig.