Skip to content

Revise start_driver.sh#3923

Merged
wattli merged 1 commit intoistio:masterfrom
wattli:driver50
Mar 3, 2018
Merged

Revise start_driver.sh#3923
wattli merged 1 commit intoistio:masterfrom
wattli:driver50

Conversation

@wattli
Copy link
Copy Markdown
Contributor

@wattli wattli commented Mar 3, 2018

No description provided.

@wattli wattli requested review from a team and myidpt March 3, 2018 00:08
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Mar 3, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: wattli

Assign the PR to them by writing /assign @wattli in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 3, 2018

@wattli: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh 1434f5b link /test istio-unit-tests
prow/istio-presubmit.sh 1434f5b link /test istio-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2018 •
edited
Loading

Codecov Report

Merging #3923 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #3923    +/-   ##
=======================================
- Coverage      76%     76%   -<1%     
=======================================
  Files         297     297            
  Lines       26735   27269   +534     
=======================================
+ Hits        20259   20565   +306     
- Misses       5192    5375   +183     
- Partials     1284    1329    +45
Impacted Files Coverage Δ
...lot/pkg/serviceregistry/cloudfoundry/controller.go 75% <0%> (-10%) ⬇️
pilot/pkg/config/memory/monitor.go 82% <0%> (-9%) ⬇️
mixer/adapter/solarwinds/log_handler.go 50% <0%> (-7%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 64% <0%> (-4%) ⬇️
pilot/pkg/serviceregistry/kube/queue.go 86% <0%> (-3%) ⬇️
mixer/adapter/opa/opa.go 79% <0%> (-3%) ⬇️
...olarwinds/internal/papertrail/papertrail_logger.go 59% <0%> (-3%) ⬇️
pilot/pkg/config/kube/ingress/controller.go 93% <0%> (-2%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 68% <0%> (-1%) ⬇️
mixer/adapter/fluentd/fluentd.go 76% <0%> (-1%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c509392...1434f5b. Read the comment docs.

@wattli wattli merged commit afd5911 into istio:master Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@myidpt myidpt myidpt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wattli @istio-merge-robot @istio-testing @myidpt @googlebot