Skip to content

Pilot e2e test support for local docker registry#3920

Merged
nmittler merged 2 commits intoistio:masterfrom
nmittler:local_registry
Mar 5, 2018
Merged

Pilot e2e test support for local docker registry#3920
nmittler merged 2 commits intoistio:masterfrom
nmittler:local_registry

Conversation

@nmittler
Copy link
Copy Markdown
Contributor

@nmittler nmittler commented Mar 2, 2018

  • Various changes to the e2e tests
  • Re-introducing old mixer docs (with many changes) for
    running a local docker registry in k8s.

@nmittler nmittler requested review from a team and ZackButcher March 2, 2018 23:19
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@46d8682). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3920   +/-   ##
========================================
  Coverage          ?     76%           
========================================
  Files             ?     297           
  Lines             ?   27178           
  Branches          ?       0           
========================================
  Hits              ?   20506           
  Misses            ?    5356           
  Partials          ?    1316

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d8682...83f0d5e. Read the comment docs.

@nmittler
Pilot e2e test support for local docker registry
19c5ff9 
- Various changes to the e2e tests
- Re-introducing old mixer docs (with many changes) for
running a local docker registry in k8s.
ZackButcher
ZackButcher reviewed Mar 5, 2018
View reviewed changes
tests/util/localregistry/README.md Outdated
If you're running e2e tests, you can set the test flags:

```shell
$ go test <TEST_PATH> -hub=localhost:5001 -tag=latest
Copy link
Copy Markdown
Contributor

@ZackButcher ZackButcher Mar 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localhost:5000, right?

Copy link
Copy Markdown
Contributor Author

@nmittler nmittler Mar 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

tests/util/localregistry/README.md Outdated
You can also modify the image URLs in your deployment yaml files directly:

```yaml
image: localhost:50001/<APP_NAME>:latest
Copy link
Copy Markdown
Contributor

@ZackButcher ZackButcher Mar 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5000 here too, right?

Copy link
Copy Markdown
Contributor Author

@nmittler nmittler Mar 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@nmittler
Copy link
Copy Markdown
Contributor Author

nmittler commented Mar 5, 2018

@ZackButcher PTAL

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 5, 2018

@nmittler: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh 83f0d5e link /test istio-unit-tests
prow/istio-presubmit.sh 83f0d5e link /test istio-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ZackButcher
ZackButcher approved these changes Mar 5, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@ZackButcher ZackButcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Mar 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ZackButcher

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@nmittler nmittler merged commit 7ba4568 into istio:master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZackButcher ZackButcher ZackButcher approved these changes

Assignees

@ZackButcher ZackButcher

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nmittler @istio-testing @istio-merge-robot @ZackButcher @googlebot