Skip to content

Init integration framework doc#3914

Merged
ldemailly merged 1 commit intoistio:masterfrom
yutongz:integration_doc-1
Mar 5, 2018
Merged

Init integration framework doc#3914
ldemailly merged 1 commit intoistio:masterfrom
yutongz:integration_doc-1

Conversation

@yutongz
Copy link
Copy Markdown
Contributor

@yutongz yutongz commented Mar 2, 2018

Add formal doc for integration test framework, preparing for "fixit"

@yutongz yutongz requested a review from a team March 2, 2018 21:21
@yutongz yutongz requested a review from hklai March 2, 2018 21:21
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Mar 2, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: sebastienvas

Assign the PR to them by writing /assign @sebastienvas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2018 •
edited
Loading

Codecov Report

Merging #3914 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #3914    +/-   ##
=======================================
- Coverage      76%     76%   -<1%     
=======================================
  Files         297     297            
  Lines       26725   27028   +303     
=======================================
+ Hits        20254   20391   +137     
- Misses       5203    5327   +124     
- Partials     1268    1310    +42
Impacted Files Coverage Δ
mixer/adapter/stackdriver/stackdriver.go 55% <0%> (-15%) ⬇️
mixer/adapter/solarwinds/log_handler.go 50% <0%> (-7%) ⬇️
security/pkg/caclient/client.go 89% <0%> (-2%) ⬇️
mixer/adapter/redisquota/redisquota.go 86% <0%> (-2%) ⬇️
mixer/template/sample/template.gen.go 55% <0%> (ø) ⬇️
mixer/adapter/dogstatsd/dogstatsd.go 100% <0%> (ø) ⬆️
mixer/adapter/memquota/keys.go 100% <0%> (ø) ⬆️
mixer/adapter/memquota/memquota.go 100% <0%> (ø) ⬆️
mixer/adapter/stdio/stdio.go 100% <0%> (ø) ⬆️
pkg/cache/lruCache.go 100% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007c793...0cd8712. Read the comment docs.

@yutongz
Copy link
Copy Markdown
Contributor Author

yutongz commented Mar 5, 2018

/test all

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 5, 2018

@yutongz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-presubmit.sh 0cd8712 link /test istio-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly ldemailly merged commit 18a20f9 into istio:master Mar 5, 2018
@yutongz
Copy link
Copy Markdown
Contributor Author

yutongz commented Mar 5, 2018

Thanks! @ldemailly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hklai hklai Awaiting requested review from hklai

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yutongz @istio-merge-robot @istio-testing @ldemailly @googlebot