Missed a change for prometheus.#3796
Merged
istio-merge-robot merged 3 commits intomasterfrom Feb 27, 2018
Merged
Conversation
Added nodeport in a style consistent with ingress. This is useful for minikube. Right now it is not recommended to create an external address for prom, since external auth is missing, so removed the option.
Codecov Report
@@ Coverage Diff @@
## master #3796 +/- ##
=======================================
- Coverage 76% 76% -<1%
=======================================
Files 291 291
Lines 26782 26899 +117
=======================================
+ Hits 20352 20393 +41
- Misses 5127 5194 +67
- Partials 1303 1312 +9
Continue to review full report at Codecov.
|
ldemailly
reviewed
Feb 27, 2018
| # istio ingress configuration | ||
| service: | ||
| # By default istio ingress uses LoadBalancer type of service | ||
| # to use NodePort, it needs to be enabled and desired port specified |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added nodeport in a style consistent with ingress. This is useful for
minikube. Right now it is not recommended to create an external address
for prom, since external auth is missing, so removed the option. We may add
it later in a consistent way for all internal services.