Skip to content

Add service for Istio CA health check probe.#3793

Merged
istio-merge-robot merged 1 commit intoistio:masterfrom
myidpt:fixprobeyaml
Feb 27, 2018
Merged

Add service for Istio CA health check probe.#3793
istio-merge-robot merged 1 commit intoistio:masterfrom
myidpt:fixprobeyaml

Conversation

@myidpt
Copy link
Copy Markdown

@myidpt myidpt commented Feb 26, 2018

With the service "istio-ca", Istio CA health check probe is able to call the Istio CA gRPC service though the service name "istio-ca".

@myidpt myidpt requested a review from a team February 26, 2018 23:50
Copy link
Copy Markdown
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldemailly
Copy link
Copy Markdown
Member

/lgtm

please fix the ingress issue as it will eventually hide a bug
(test simple ingress failure #3757)

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit c24c689 into istio:master Feb 27, 2018
@myidpt
Copy link
Copy Markdown
Author

myidpt commented Feb 27, 2018

@ldemailly we still need https://github.com/istio/istio/blob/master/install/kubernetes/mesh-expansion.yaml#L65 for the mesh expansion. this PR adds a CA internal service (not external service), for health check probe to be able to find the service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants