Update go-control-plane#3792
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
you need to make your vendor PR first |
|
pilot/pkg/proxy/envoy/v2/placeholder.go:37:2:error: ineffectual assignment to server (ineffassign) |
| if err != nil { | ||
| log.Errorf("failed to listen") | ||
| } | ||
| _ = server |
|
This is dead code: see build !ignore flag above.
…On Mon, Feb 26, 2018 at 4:08 PM Laurent Demailly ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pilot/pkg/proxy/envoy/v2/placeholder.go
<#3792 (comment)>:
> @@ -40,6 +40,7 @@ func RunXDS(ctx context.Context, config cache.Cache, port uint) {
if err != nil {
log.Errorf("failed to listen")
}
+ _ = server
??
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#3792 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJGIxuv6rsw0mYMQMrGc6ifSy9x4LGvCks5tY0eKgaJpZM4SUH0M>
.
|
|
merged the vendor so please switch your vendor to head optional, another round with master in the toml (but that one can wait next update) |
|
/retest |
1 similar comment
|
/retest |
|
FAIL istio.io/istio/mixer/adapter/solarwinds/internal/appoptics 0.578s |
|
Nothing to do with this PR. Flake? |
Signed-off-by: Kuat Yessenov <kuat@google.com>
Codecov Report
@@ Coverage Diff @@
## master #3792 +/- ##
=======================================
- Coverage 77% 76% -<1%
=======================================
Files 291 291
Lines 26847 26930 +83
=======================================
+ Hits 20423 20433 +10
- Misses 5120 5191 +71
- Partials 1304 1306 +2
Continue to review full report at Codecov.
|
ldemailly
left a comment
There was a problem hiding this comment.
only because it's not used :-)
|
/test e2e-suite-rbac-auth /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@kyessenov: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
probably not because of you but... I0227 00:40:47.469] istio-ca-9fd9f4869-tlsb8 0/1 ImagePullBackOff 0 4m seems like something is broken - @costinm maybe your pr ? |
|
never mind the failure is most likely #3645 |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Signed-off-by: Kuat Yessenov kuat@google.com